Fix Visual Picker Checkbox doesn't work in Firefox when checkbox is c…

…licked on directly (#4102) * fix(visual-picker): fix checkbox click * fix(visual-picker): add changeset * Update modern-starfishes-matter.md
twilio-labs · Oct 14, 2024 · afba2ae · afba2ae
1 parent 239b2c5
commit afba2ae
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/.changeset/modern-starfishes-matter.md b/.changeset/modern-starfishes-matter.md
@@ -0,0 +1,6 @@
+---
+"@twilio-paste/visual-picker": patch
+"@twilio-paste/core": patch
+---
+
+[Visual Picker]: Fix Visual Picker checkbox doesn't work in firefox when checkbox is clicked on directly
diff --git a/packages/paste-core/components/visual-picker/src/VisualPickerCheckbox.tsx b/packages/paste-core/components/visual-picker/src/VisualPickerCheckbox.tsx
@@ -115,7 +115,7 @@ export const VisualPickerCheckbox = React.forwardRef<HTMLInputElement, VisualPic
         <BaseRadioCheckboxLabel disabled={disabled} htmlFor={checkboxId} id={labelId}>
           <ScreenReaderOnly>{labelText}</ScreenReaderOnly>
           <BaseRadioCheckboxControl
-            onClick={(e) => e.stopPropagation()}
+            onClick={(e) => e.preventDefault()}
             borderRadius="borderRadius20"
             element={`${element}_CONTROL`}
             disabled={disabled}