Skip to content

Commit

Permalink
Remove reference to all missing files parsed from failed SQ targets.
Browse files Browse the repository at this point in the history
Prepare for {D680506} by cherry-picking all the fixes for missing or misnamed
rules input files. Will rebase D680506 after this lands and remove the duplicate changes.

Missing files were determined by using a few ad hoc scripts.

first downloaded all the failed logs from {D680506} via log collector:
`./language-server/log-collector/collect-logs https://ton.smf1.twitter.com/sqservice/prod_666255_runTests`
Then scanned the logs for the missing input files pattern:
` rg -oIN  "missing input file '(\S+)'" language-server/log-collector/.cache/ | sort | uniq`
Then parsed the missing file names into package and label pairs via a python script:
```python
raw_lines = input().split(',')

print(" ".join([line[line.find("'")+3:-1] for line in raw_lines]))
```

The using bash and sed found and replaced the file name segments in each package:

```
❯ for p in `rg -oIN  "missing input file '(\S+)'" language-server/log-collector/.cache/ | sort | uniq | paste -sd "," - | python3 ../sandbox/invalid_file_refs.py`; do
package="${p%:*}/BUILD"
f=${p#*:}
echo "$package" "$f"
sed -I "" s~\"$f\"~~g "$package"
done
```

JIRA Issues: DPB-13435

Differential Revision: https://phabricator.twitter.biz/D840257
  • Loading branch information
Henry Fuller authored and jenkins committed Feb 25, 2022
1 parent a4666d6 commit 6d0b70d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion finagle-serversets/src/main/thrift/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ create_thrift_libraries(

python_thrift_library(
name = "thrift-python",
sources = ["com/twitter/thrift/endpoint.thrift"],
sources = [],
tags = ["bazel-compatible"],
)

Expand Down

0 comments on commit 6d0b70d

Please sign in to comment.