Moving the update_in_comment option from the process param into the config file. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cropalato
changed the title
cropalato
changed the title
twotired
requested changes
Jul 4, 2023
pkg/config/config.go
Outdated
| @@ -149,6 +149,9 @@ type ReceiverConfig struct { | |||
| // Label copy settings | |||
| AddGroupLabels bool `yaml:"add_group_labels" json:"add_group_labels"` | |||
|
|
|||
| // Flag to auto-resolve opened issue when the alert is resolved. | |||
There was a problem hiding this comment.
this should be "// Flag to enable updates in comments"
pkg/config/config_test.go
Outdated
| @@ -385,6 +388,8 @@ func newReceiverTestConfig(mandatory []string, optional []string) *receiverTestC | |||
| var value reflect.Value | |||
| if name == "AddGroupLabels" { | |||
| value = reflect.ValueOf(true) | |||
| } else if name == "UpdateInComment" { | |||
There was a problem hiding this comment.
indentation appears inconsistent
- Changed comment; - Replaced space indentation by tab indentation.
|
Fixed. |
|
@twotired Do you want me to change something else? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I really like that feature, thanks for your PR, But I agree with @MytkoEnko ( prometheus-community#161 (comment) ). Should be more flexible if we use config file to manage that.
So, here is my 2 cents...