Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: consolidate port connection checks into a single method #78

Merged
merged 1 commit into from
Mar 13, 2025

Conversation

SakuraPuare
Copy link
Contributor

完全没有必要引入这个telnet库 只需要用socket即可

提取了函数

@SakuraPuare
Copy link
Contributor Author

fix #77

@SakuraPuare
Copy link
Contributor Author

没想到是这样调用的。。。

image

一般来说 这样的函数不会在类里面

@txperl
Copy link
Owner

txperl commented Mar 13, 2025

不好意思,当年写的时候特别喜欢反射,到处用然后就是这个结果了。((

也导致现在连基本的 Lint 的没有,维护难度大增。

@txperl txperl merged commit f82da58 into txperl:master Mar 13, 2025
@txperl
Copy link
Owner

txperl commented Mar 13, 2025

谢谢你的 PR,已经合并咯。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants