pallas-primitives: fix PostAlonzoAuxiliaryData #323
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think we should change this in Alonzo primitives. The plutus_v1 vs v2 was introduced in Babbage. The babbage primitives already contemplate that CDDL change: pallas/pallas-primitives/src/babbage/model.rs Line 503 in 2b5f22d |
|
Yep, my bad. I must have gotten confused late at night. Closing now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a small difference between the cddl and the rust definition for
PostAlonzoAuziliaryData.I wasn't sure if it was intentional or a mistake but I made the adjustment and all tests still pass.
If this is intentional feel free to close this PR. It was a simple adjustment so no worries.