Update db.migrations.operations
#2349
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Viicos
commented
Aug 22, 2024
Comment on lines
+11
to
+17
| class OperationCategory(str, Enum): | ||
| ADDITION = "+" | ||
| REMOVAL = "-" | ||
| ALTERATION = "~" | ||
| PYTHON = "p" | ||
| SQL = "s" | ||
| MIXED = "?" |
There was a problem hiding this comment.
Having the actual values seems to be recommended.
Viicos
commented
Aug 22, 2024
Comment on lines
+20
to
+25
| reversible: ClassVar[bool] | ||
| reduces_to_sql: ClassVar[bool] | ||
| atomic: ClassVar[bool] | ||
| elidable: ClassVar[bool] | ||
| serialization_expand_args: ClassVar[list[str]] | ||
| category: ClassVar[OperationCategory | None] |
There was a problem hiding this comment.
I believe they are all class vars?
|
The stubtest error is annoying.. Looks like mixing |
Viicos
force-pushed
the
operation-category
branch
from
efc10cb
to
79183d1
Compare
sobolevn
reviewed
Aug 25, 2024
| atomic: ClassVar[bool] | ||
| elidable: ClassVar[bool] | ||
| serialization_expand_args: ClassVar[list[str]] | ||
| category: ClassVar[OperationCategory | None] | ||
| _constructor_args: tuple[Sequence[Any], dict[str, Any]] |
There was a problem hiding this comment.
Why do we have this protected member here? Is it still useful?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made things!
Related issues