Fill remaining missing hints & disallow partial hints #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disallow untyped/incomplete function definitions. Just like django-stubs.
intgr
force-pushed
the
disallow-untyped-incomplete-defs
branch
from
e4087ea
to
766f8d1
Compare
intgr
commented
Oct 5, 2023
Comment on lines
+30
to
+32
| [mypy-yaml.*] | ||
| disallow_untyped_defs = false | ||
| disallow_incomplete_defs = false |
There was a problem hiding this comment.
I think these are necessary due to the way pytest-mypy-plugins works.
Mypy ordinarily ignores errors from site-packages imports, but they aren't ignored in tests.
There was a problem hiding this comment.
This can be a new bug / feature request in pytest-mypy-plugins. Users should not see this.
There was a problem hiding this comment.
👍 Reported issue typeddjango/pytest-mypy-plugins#134
sobolevn
approved these changes
Oct 5, 2023
This was referenced Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disallow untyped/incomplete function definitions (
disallow_untyped_defs = true,disallow_incomplete_defs = true)But using
_typeshed.Incompleteinstead ofAnyas the placeholder type.Related issues
mypy.iniconfig with django-stubs #479