feat(abg)!: replace data class perks by code generation in bindings #1644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Vampire
force-pushed
the
vampire/no-data-bindings
branch
2 times, most recently
from
fcb93fe to
f2e6c05
Compare
Vampire
force-pushed
the
vampire/versioned-routes
branch
from
6e0c383 to
05942ab
Compare
This was referenced Sep 8, 2024
Vampire
force-pushed
the
vampire/no-data-bindings
branch
from
f2e6c05 to
f9bff8a
Compare
Vampire
changed the base branch from
vampire/versioned-routes
to
vampire/binding-version-v2
Vampire
force-pushed
the
vampire/no-data-bindings
branch
2 times, most recently
from
26ff564 to
915be83
Compare
Vampire
force-pushed
the
vampire/binding-version-v2
branch
from
5b756f4 to
a485fe4
Compare
Vampire
force-pushed
the
vampire/no-data-bindings
branch
from
915be83 to
01e7a87
Compare
Vampire
force-pushed
the
vampire/binding-version-v2
branch
from
a485fe4 to
6c58c0d
Compare
Vampire
force-pushed
the
vampire/no-data-bindings
branch
from
01e7a87 to
781eb1b
Compare
Vampire
force-pushed
the
vampire/binding-version-v2
branch
from
6c58c0d to
66b9afd
Compare
Vampire
force-pushed
the
vampire/no-data-bindings
branch
from
781eb1b to
248813f
Compare
Vampire
force-pushed
the
vampire/binding-version-v2
branch
from
66b9afd to
f8e466f
Compare
Vampire
force-pushed
the
vampire/no-data-bindings
branch
from
248813f to
a5da3b1
Compare
Vampire
force-pushed
the
vampire/binding-version-v2
branch
from
f8e466f to
eb02b5a
Compare
Vampire
force-pushed
the
vampire/no-data-bindings
branch
from
a5da3b1 to
f58ac6b
Compare
Vampire
force-pushed
the
vampire/binding-version-v2
branch
from
eb02b5a to
36a0a91
Compare
Vampire
force-pushed
the
vampire/no-data-bindings
branch
from
f58ac6b to
f11c738
Compare
Vampire
force-pushed
the
vampire/binding-version-v2
branch
from
36a0a91 to
8895541
Compare
Vampire
force-pushed
the
vampire/no-data-bindings
branch
from
f11c738 to
5e87ccb
Compare
Vampire
force-pushed
the
vampire/binding-version-v2
branch
from
8895541 to
4281b5d
Compare
Vampire
force-pushed
the
vampire/no-data-bindings
branch
from
5e87ccb to
c89a7e1
Compare
krzema12
reviewed
Oct 17, 2024
| - The `equals` method will work like before. | ||
| - The `hashCode` method will work like before. | ||
| - The `toString` method will work like before. | ||
| - Destructuring assignments are not possible anymore as this will likely break silently or during |
There was a problem hiding this comment.
I initially wanted to ask why this change is made under v2 of the bindings server, and it's probably because of this remark about destructuring. I think it's enough to provide component1...componentN functions, then destructuring should work, and we wouldn't have to bump the route version just yet.
There was a problem hiding this comment.
My plan is to revisit our discussion we had on Slack to ensure that there's no simpler option to achieve what we want. Sometimes ideas come after time 😄
There was a problem hiding this comment.
Let's see if someone has some interesting take on this: https://kotlinlang.slack.com/archives/C8C4JTXR7/p1729233924861659
There was a problem hiding this comment.
I think it's enough to provide component1...componentN functions, then destructuring should work, and we wouldn't have to bump the route version just yet.
It would not be, as said on Slack.
It was intentional I left them out.
And additionally the copy method now also enforces named-arguments which is also a breaking change.
So to replicate here too, the goal here was not to somehow make it compatible with the upcoming Kotlin versions, but to improve the API to the originally intended way.
That this also fixes the copy visibility thing is merely a by-product and just was the trigger to finally have a look at it.
Vampire
force-pushed
the
vampire/binding-version-v2
branch
from
4281b5d to
1f9acc7
Compare
Vampire
force-pushed
the
vampire/no-data-bindings
branch
from
c89a7e1 to
fb71bbb
Compare
Vampire
force-pushed
the
vampire/no-data-bindings
branch
from
6a4b37c to
e1c02e0
Compare
Vampire
force-pushed
the
vampire/binding-version-v2
branch
from
9d65dc9 to
cd64a8e
Compare
Vampire
force-pushed
the
vampire/no-data-bindings
branch
from
e1c02e0 to
f416585
Compare
Vampire
force-pushed
the
vampire/binding-version-v2
branch
from
cd64a8e to
62d0334
Compare
Vampire
force-pushed
the
vampire/no-data-bindings
branch
from
f416585 to
38ae26e
Compare
Vampire
force-pushed
the
vampire/binding-version-v2
branch
from
62d0334 to
1692740
Compare
Vampire
force-pushed
the
vampire/no-data-bindings
branch
from
38ae26e to
78478e8
Compare
Vampire
changed the base branch from
vampire/binding-version-v2
to
graphite-base/1644
Vampire
changed the base branch from
graphite-base/1644
to
vampire/binding-version-v2
Vampire
changed the base branch from
vampire/binding-version-v2
to
graphite-base/1644
Vampire
force-pushed
the
graphite-base/1644
branch
from
0d20faa to
361c817
Compare
Vampire
force-pushed
the
vampire/no-data-bindings
branch
from
2e625de to
792beb4
Compare
Vampire
changed the base branch from
graphite-base/1644
to
vampire/binding-version-v2
Vampire
force-pushed
the
vampire/no-data-bindings
branch
from
792beb4 to
6edeaac
Compare
Vampire
force-pushed
the
vampire/binding-version-v2
branch
2 times, most recently
from
29455da to
5ea294c
Compare
Vampire
force-pushed
the
vampire/no-data-bindings
branch
2 times, most recently
from
44c7839 to
a157006
Compare
Vampire
force-pushed
the
vampire/binding-version-v2
branch
from
5ea294c to
56f3508
Compare
Vampire
force-pushed
the
vampire/no-data-bindings
branch
from
a157006 to
ff4ec7a
Compare
Vampire
force-pushed
the
vampire/binding-version-v2
branch
from
56f3508 to
aa3ec98
Compare
Vampire
force-pushed
the
vampire/no-data-bindings
branch
from
ff4ec7a to
63a6397
Compare
Vampire
force-pushed
the
vampire/binding-version-v2
branch
from
aa3ec98 to
0a56a01
Compare
Vampire
changed the base branch from
vampire/binding-version-v2
to
graphite-base/1644
Vampire
force-pushed
the
graphite-base/1644
branch
from
0a56a01 to
e5b91b1
Compare
Vampire
force-pushed
the
vampire/no-data-bindings
branch
from
63a6397 to
cc802a9
Compare
Vampire
changed the base branch from
graphite-base/1644
to
vampire/binding-version-v2
Vampire
force-pushed
the
vampire/no-data-bindings
branch
from
cc802a9 to
cb23a96
Compare
Vampire
force-pushed
the
vampire/binding-version-v2
branch
from
e5b91b1 to
35fa1c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1629