Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(server): add test for using older Kotlin compiler #1757

Merged
merged 11 commits into from
Jan 1, 2025

Conversation

krzema12
Copy link
Member

@krzema12 krzema12 commented Dec 31, 2024

Part of #1756.

The goal here is to both depict the current behavior, but also save us from unintentionally having Renovate auto-merge PRs that bump Kotlin version, which results in having incompatibility in Kotlin Metadata. The details of the problem are described in #1756.

@krzema12 krzema12 changed the title Add test for using older Kotlin compiler test: add test for using older Kotlin compiler Dec 31, 2024
.github/workflows/bindings-server.main.kts Outdated Show resolved Hide resolved
.github/workflows/bindings-server.main.kts Outdated Show resolved Hide resolved
.github/workflows/bindings-server.main.kts Outdated Show resolved Hide resolved
@krzema12 krzema12 changed the title test: add test for using older Kotlin compiler test(server): add test for using older Kotlin compiler Dec 31, 2024
@krzema12 krzema12 force-pushed the add-test-for-using-older-Kotlin-compiler branch from 56e7c9c to ad54ecd Compare January 1, 2025 11:34
@krzema12 krzema12 marked this pull request as ready for review January 1, 2025 21:48
@krzema12
Copy link
Member Author

krzema12 commented Jan 1, 2025

CC @Vampire

@krzema12 krzema12 merged commit e5b9528 into main Jan 1, 2025
14 checks passed
@krzema12 krzema12 deleted the add-test-for-using-older-Kotlin-compiler branch January 1, 2025 21:49
@Vampire
Copy link
Collaborator

Vampire commented Jan 1, 2025

Nice, but is there a reason you do the installing of versions manually instead of using for example https://github.com/marketplace/actions/setup-kotlin#running-a-script-inline ?

@krzema12
Copy link
Member Author

krzema12 commented Jan 1, 2025

@Vampire I rushed it - i tried this, but Kotlin had a problem detecting this artifact, so I thought there's some problem with the bindings server not being able to work with non-major version. That's why I inlined what the action does. Let me try using the action here: #1758.
Also, you liked to the "Running a script inline" section which I believe is wrong, as I wouldn't be able to assert on Kotlin's output as I do now with grep.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants