Skip to content

Add asgiref to allowlist #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 5, 2025
Merged

Conversation

huynguyengl99
Copy link
Contributor

Prerequisite for python/typeshed#13939

The package is in the PyPI top 1000 list (ranked 195th). It is fully type-hinted and under the Django umbrella, so I think it’s safe to add to the EXTERNAL_REQ_ALLOWLIST.

Copy link
Contributor

@srittau srittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds reasonable, but please keep the list sorted.

@huynguyengl99
Copy link
Contributor Author

Oh, sorry about that! I didn’t realize the order — I updated it.

@huynguyengl99 huynguyengl99 requested a review from srittau May 5, 2025 07:28
@srittau srittau merged commit 0073cec into typeshed-internal:main May 5, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants