Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add user agent 'aws-sdk-go-v2' to regex file #583

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

akhil-jay
Copy link
Contributor

@akhil-jay akhil-jay commented May 9, 2024

Added additional user agent regex for 'aws-sdk-go-v2' seen from "aws-sdk-go-v2/1.24.1 os/linux lang/go#1.20.4 md/GOOS#linux md/GOARCH#arm64 api/sts#1.26."

Added OS parsing for 'Mac OS X' seen as "os/macos#1.2.3" and "(go1.20.1; darwin; arm64)"

@akhil-jay akhil-jay marked this pull request as draft May 9, 2024 05:18
@akhil-jay akhil-jay force-pushed the add-amazon-s3-user-agent branch 2 times, most recently from af14b9b to 5dcadb1 Compare May 9, 2024 08:48
@akhil-jay akhil-jay changed the title add user agent 'aws-sdk-go-v2' to regex file add user agent 'aws-sdk-go-v' to regex file May 9, 2024
@akhil-jay akhil-jay marked this pull request as ready for review May 9, 2024 08:49
@akhil-jay akhil-jay changed the title add user agent 'aws-sdk-go-v' to regex file add user agent 'aws-sdk-go-v2' to regex file May 9, 2024
@akhil-jay
Copy link
Contributor Author

akhil-jay commented May 15, 2024

Hi @commenthol I wanted to add some parsing for regex related to aws-sdk-go-v2 and parsing for os for a few user agent I have come across recently.

@akhil-jay akhil-jay marked this pull request as draft May 22, 2024 10:09
@akhil-jay akhil-jay marked this pull request as ready for review May 22, 2024 10:09
regexes.yaml Outdated Show resolved Hide resolved
regexes.yaml Outdated Show resolved Hide resolved
@akhil-jay akhil-jay force-pushed the add-amazon-s3-user-agent branch from 5dcadb1 to 8b74ca5 Compare September 20, 2024 06:15
@akhil-jay akhil-jay requested a review from lbarthon September 20, 2024 06:16
@akhil-jay akhil-jay force-pushed the add-amazon-s3-user-agent branch from 8b74ca5 to 7d42b14 Compare September 20, 2024 06:17
@lbarthon lbarthon merged commit 95ecd15 into ua-parser:master Sep 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants