Skip to content
This repository has been archived by the owner on Oct 2, 2019. It is now read-only.

Fixed lint warnings #91

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions bin/idl.js
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ var mkdirp = require('mkdirp');
var DebugLogtron = require('debug-logtron');
var extend = require('xtend');
var textTable = require('text-table');
var parallel = require('run-parallel');
var cpr = require('cpr');
var rc = require('rc');
var rcUtils = require('rc/lib/utils');
Expand Down Expand Up @@ -484,7 +483,7 @@ function fetch(service, cb) {
self.update(onUpdate);

function onUpdate(err) {
if (err != null) {
if (err !== null) {
return cb(err);
}

Expand Down Expand Up @@ -524,7 +523,6 @@ function fetchOneService(service, cb) {
return cb(err);
}

var alreadyFetched = findService(localMeta.toJSON(), service);
var existsInRegistry = findService(self.meta.toJSON(), service);

if (!existsInRegistry) {
Expand Down Expand Up @@ -1019,7 +1017,8 @@ function toString() {
}

// If configured in .idlrc, runs a command that ensures that subsequent git
// commands interacting with the git registry's repository run without interactive authentication prompts.
// commands interacting with the git registry's repository run without
// interactive authentication prompts.
// This is important since these command typically run in a pty to obscure hide
// their output and detect any interactive authentication prompts (via PAM)
// that might open /dev/tty to avoid mucking with stdio.
Expand Down
2 changes: 1 addition & 1 deletion git-commands.js
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ function addCommitTagAndPushToOrigin(opts, callback) {
var ctx = {
cwd: opts.cwd,
logger: opts.logger,
debugGit: opts.debugGit,
debugGit: opts.debugGit
};

series([
Expand Down
2 changes: 1 addition & 1 deletion test/unit/get-dependencies.js
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ test('getServiceDependenciesFromIncludes',
'github.com/a-team/bar',
'github.com/b-team/baz',
'github.com/b-team/qux',
'github.com/company/common',
'github.com/company/common'
];

assert.deepEqual(serviceDependencies, expected);
Expand Down