-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Sendable
compliant protocols and classes
#254
Merged
sidepelican
merged 4 commits into
uber:master
from
nhiroyasu:suppress-sendable-protocol-warnings
Apr 15, 2024
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
2a79ad9
Implemented inheritance of @unchecked Sendable for mock classes confo…
nhiroyasu 7bee97d
Corrected syntax for inheritedTypes in template processing
nhiroyasu 425498c
Fixed CoW overhead issues
nhiroyasu 30cd46c
Removed unnecessary imports
nhiroyasu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,88 @@ | ||
import MockoloFramework | ||
|
||
let sendableProtocol = """ | ||
/// \(String.mockAnnotation) | ||
public protocol SendableProtocol: Sendable { | ||
func update(arg: Int) -> String | ||
} | ||
""" | ||
|
||
let sendableProtocolMock = """ | ||
|
||
|
||
|
||
public class SendableProtocolMock: SendableProtocol, @unchecked Sendable { | ||
public init() { } | ||
|
||
|
||
public private(set) var updateCallCount = 0 | ||
public var updateHandler: ((Int) -> (String))? | ||
public func update(arg: Int) -> String { | ||
updateCallCount += 1 | ||
if let updateHandler = updateHandler { | ||
return updateHandler(arg) | ||
} | ||
return "" | ||
} | ||
} | ||
|
||
""" | ||
|
||
let uncheckedSendableClass = """ | ||
/// \(String.mockAnnotation) | ||
public class UncheckedSendableClass: @unchecked Sendable { | ||
func update(arg: Int) -> String | ||
} | ||
""" | ||
|
||
let uncheckedSendableClassMock = """ | ||
|
||
|
||
|
||
public class UncheckedSendableClassMock: UncheckedSendableClass, @unchecked Sendable { | ||
public init() { } | ||
|
||
|
||
private(set) var updateCallCount = 0 | ||
var updateHandler: ((Int) -> (String))? | ||
override func update(arg: Int) -> String { | ||
updateCallCount += 1 | ||
if let updateHandler = updateHandler { | ||
return updateHandler(arg) | ||
} | ||
return "" | ||
} | ||
} | ||
|
||
""" | ||
|
||
let confirmedSendableProtocol = """ | ||
public protocol SendableSendable: Sendable { | ||
func update(arg: Int) -> String | ||
} | ||
|
||
/// \(String.mockAnnotation) | ||
public protocol ConfirmedSendableProtocol: SendableSendable { | ||
} | ||
""" | ||
|
||
let confirmedSendableProtocolMock = """ | ||
|
||
|
||
|
||
public class ConfirmedSendableProtocolMock: ConfirmedSendableProtocol, @unchecked Sendable { | ||
public init() { } | ||
|
||
|
||
public private(set) var updateCallCount = 0 | ||
public var updateHandler: ((Int) -> (String))? | ||
public func update(arg: Int) -> String { | ||
updateCallCount += 1 | ||
if let updateHandler = updateHandler { | ||
return updateHandler(arg) | ||
} | ||
return "" | ||
} | ||
} | ||
|
||
""" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
class SendableTests: MockoloTestCase { | ||
func testSendableProtocol() { | ||
verify(srcContent: sendableProtocol, | ||
dstContent: sendableProtocolMock) | ||
} | ||
|
||
func testUncheckedSendableClass() { | ||
verify(srcContent: uncheckedSendableClass, | ||
dstContent: uncheckedSendableClassMock, | ||
declType: .classType) | ||
} | ||
|
||
func testConfirmingSendableProtocol() { | ||
verify(srcContent: confirmedSendableProtocol, | ||
dstContent: confirmedSendableProtocolMock) | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this can be more beautify like this: