Updated Weekly Luck Record function to also calculate and report Season Luck Record and Ranking/Place #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdpeca
force-pushed
the
feature(luck_season_record_with_rank)
branch
2 times, most recently
from
b193ff0 to
f5d3ff3
Compare
…on Luck Record and Ranking/Place
cdpeca
force-pushed
the
feature(luck_season_record_with_rank)
branch
from
f5d3ff3 to
6d34885
Compare
|
Rebased with upstream/main commits and resolved conflict on report table header. Should now be good to merge this feature branch into upstream/main |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature enhances the Team Luck Rankings section by adding a Season Record for Luck in addition to the Weekly Record for Luck. On top of that it also calculates the Season Ranking/Place for the Season Record. With this feature the last column of the Team Luck Rankings now provides 3 distinct data points:
This allows for a very useful analysis of what a record would look like for everyone in a league if you eliminated the positive/negative luck. Probably the most useful comparison that can be made of what a team's record would really look like compared to everyone else if you eliminate luck as a variable.