-
-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(deck): Use valve-firmware #1137
base: main
Are you sure you want to change the base?
Conversation
instead of manually installing Steam Deck firmware files.
Greetings from the PlaytronOS project. :-) I'm the Director of Linux Engineering over at Playtron. Although we are not directly using Bazzite, we want to help contribute back to various parts of the Linux gaming community in any way that we can! By packaging the firmware files as a RPM, this simplifies Bazzite's install of the files. They can also be easily installed and updated on other Fedora distributions now. Using Bazzite's code as a starting point, I turned the firmware installation into a RPM package with the following changes:
I did a test build and it is working. However, I did not try rebasing to it using an rpm-ostree distribution.
|
When testing the installation of the firmware along with kernel-fsync, my OLED Steam Deck finally going Wi-Fi working! But audio still does not work. I tested the RPM on Fedora 40. I also tried manually installing the firmware files on both Arch Linux (using
|
Hi Luke, Essentially all copr software needs to be open source So that is something to consider. |
Hey @antheas, thanks for the information! I wasn't aware of that. PlaytronOS also has a public RPM repository that is hosted on an AWS S3 bucket. I'll look into transitioning the RPM over to there. |
We're actually about to go through a major restructure of our AWS S3 repositories next week. I'll follow-up once that's done. |
I wonder if this package can be contributed to the rpmfusion project? Then it is not adding another repository. |
@dylanmtaylor Our long-term goal for every package we maintain in PlaytronOS is to upstream them into Fedora and help maintain them there. I used to work at Red Hat and maintained a few gaming related packages during that time. I know it is easier said than done. In this specific scenario, I'd like to see if we can work with Valve to add their firmware blobs to the upstream RPM Fusion is our goal for the short-term, too. I'm not sure how long it would take for this package to be accepted and I can start the submission soon. |
This is a brilliant idea, actually. I'd love to see that too. |
Early last week, I reached out to a few members of the SteamOS team about upstreaming their firmware. I got no response. After talking with a few folks in the community, it seems that they are more interested in leaving the firmware blobs up to the hardware vendors to support upstream. I love Valve. They're one of my favorite companies. However, from my winesapOS project and other upstream projects I'm involved in, I've tried to work close with the SteamOS team for years and it has been a struggle. Valve has not been interested in patches to improve compatibility for other devices. The situation has slightly improved now that a 2024 public release of SteamOS has been rumored. But adding additional hardware support could accidentally break their Steam Deck support. They are also in no hurry to upstream their hardware support as everything just works on the Steam Deck OLED with SteamOS. As of Linux 6.9, both sound and Wi-Fi still do not work for upstream Linux distributions. The Steam Deck has custom firmware files for sound. The Sound Open Firmware (SOF) project is working on fixing up support with alternative firmware but it still has a lot of issues. For Wi-Fi, some firmware files are available but they are buggy. I recall SteamOS adding a handful of patches to their Linux kernel to deal with that. My Steam Deck OLED was affected and had no Wi-Fi on SteamOS for the first month I owned it. Next Steps The I'm also open to other suggestions if there is another, more widely used, repository where we could contribute this to. Our goal here is simply to make it easy for any RPM-based distribution to be able to install better Steam Deck OLED support. |
Wonder if OpenSUSE's build service would work. I can't find information about whether they require build inputs to be open source. |
I apologize for my delayed response, I meant to follow-up on this a lot sooner. I don't think that there is any violation of the Fedora Copr guidelines. Reading into this further, both the Copr and RPM Fusion Free follow the same guidelines as Fedora itself. The one exception to packaging proprietary blobs is for redistributing firmware. That's allowed. The license from the SteamOS package is that same as the https://docs.fedoraproject.org/en-US/legal/license-approval/#_licenses_allowed_for_firmware I'd have to do more research into the OBS guidelines if that's another avenue we want to explore. |
instead of manually installing Steam Deck firmware files.