Make padding 20px (visually) throughout the application #679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashuntu
pushed a commit
to ashuntu/app-center
that referenced
this pull request
Feb 28, 2024
* init commit * lint * format * format Co-authored-by: Frederik Feichtmeier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just gathering feedback to see if this look is preferred over the older one. The padding here is 20px visually for consistency. I still need to cleanup some widgets which don't make use the available constants.
simplescreenrecorder-2023-01-01_16.28.24.mp4
The only issue I could see being introduced here is the fact that a Yaru banner that is currently hovered on will look slightly out of place because the border is now shown. Though IMO this is a trade-off that is worth it given that everything now looks properly aligned.
Fixes #676