Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set harness clock to default clk freq | Use combined clk frag. #2144

Closed
wants to merge 1 commit into from

Conversation

abejgonzalez
Copy link
Contributor

Use the nicer WithUniformBusFrequencies fragment which sets all the buses to the same clock. Additionally set the harness clock to the same frequency (otherwise the harness clock is set to 100MHz by default).

Related PRs / Issues:

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • RTL change
  • Software change (RISC-V software)
  • Build system change
  • Other

Contributor Checklist:

  • Did you set main as the base branch?
  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • Did you mark the PR with a changelog: label?
  • (If applicable) Did you update the conda .conda-lock.yml file if you updated the conda requirements file?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you add a test demonstrating the PR?
  • (If applicable) Did you mark the PR as Please Backport?

CI Help:
Add the following labels to modify the CI for a set of features.
Generally, a label added only affect subsequent changes to the PR (i.e. new commits, force pushing, closing/reopening).
See ci:* for full list of labels:

  • ci:fpga-deploy - Run FPGA-based E2E testing
  • ci:local-fpga-buildbitstream-deploy - Build local FPGA bitstreams for platforms that are released
  • ci:disable - Disable CI

@abejgonzalez abejgonzalez self-assigned this Dec 5, 2024
@abejgonzalez abejgonzalez marked this pull request as ready for review December 5, 2024 18:00
Copy link
Contributor

@jerryz123 jerryz123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this change for? I believe leaving the harness at 100 MHz keeps it more "test-chip-like", since the FPGA-side "harness" won't run at more than 100 MHz.

@abejgonzalez
Copy link
Contributor Author

What is this change for? I believe leaving the harness at 100 MHz keeps it more "test-chip-like", since the FPGA-side "harness" won't run at more than 100 MHz.

This was to generate a single clock for the entire system s.t. waveforms see 1 uniform clock (I assume VCS/Verilator properly remove dead cycles if the harness/chiptop have different frequencies). This is more cosmetic than anything, I'll close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants