-
Notifications
You must be signed in to change notification settings - Fork 678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADD: submodule tacit & tacit decoder #2172
Merged
Merged
+114
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 tasks
jerryz123
reviewed
Feb 5, 2025
jerryz123
reviewed
Feb 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In .github/scripts/check-commit.sh, you should add your submodules
jerryz123
reviewed
Feb 5, 2025
generators/chipyard/src/main/scala/config/fragments/TileFragments.scala
Outdated
Show resolved
Hide resolved
jerryz123
reviewed
Feb 5, 2025
generators/chipyard/src/main/scala/config/fragments/TileFragments.scala
Outdated
Show resolved
Hide resolved
jerryz123
reviewed
Feb 5, 2025
generators/chipyard/src/main/scala/config/fragments/TileFragments.scala
Outdated
Show resolved
Hide resolved
jerryz123
reviewed
Feb 5, 2025
jerryz123
reviewed
Feb 5, 2025
jerryz123
approved these changes
Feb 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now just fix the merge conflict
6585dca
to
8a26474
Compare
iansseijelly
added a commit
that referenced
this pull request
Feb 7, 2025
da42820
to
a2bb4a1
Compare
d4f58e8
to
f875684
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs / Issues:
Type of change:
Impact:
Contributor Checklist:
main
as the base branch?changelog:<topic>
label?changelog:
label?.conda-lock.yml
file if you updated the conda requirements file?Please Backport
?CI Help:
Add the following labels to modify the CI for a set of features.
Generally, a label added only affect subsequent changes to the PR (i.e. new commits, force pushing, closing/reopening).
See
ci:*
for full list of labels:ci:fpga-deploy
- Run FPGA-based E2E testingci:local-fpga-buildbitstream-deploy
- Build local FPGA bitstreams for platforms that are releasedci:disable
- Disable CI