Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MNV and generateIndex #817

Merged
merged 8 commits into from
Nov 8, 2023
Merged

Fix MNV and generateIndex #817

merged 8 commits into from
Nov 8, 2023

Conversation

zhuchcn
Copy link
Member

@zhuchcn zhuchcn commented Oct 23, 2023

Description

Two issues fixed in this PR:

  1. Adjacent variants were not merged as MNVs successfully. The function always exited with nothing.
  2. Because of the updating to on-disk GTF, the coding transcripts were not generated and saved successfully. filterFasta is the only command affected.

Closes #...

Checklist

  • This PR does NOT contain PHI or germline genetic data. A repo may need to be deleted if such data is uploaded. Disclosing PHI is a major problem.
  • This PR does NOT contain molecular files, compressed files, output files such as images (e.g. .png, .jpeg), .pdf, .RData, .xlsx, .doc, .ppt, or other non-plain-text files. To automatically exclude such files using a .gitignore file, see here for example.
  • I have read the code review guidelines and the code review best practice on GitHub check-list.
  • The name of the branch is meaningful and well formatted following the standards, using [AD_username (or 5 letters of AD if AD is too long)]-[brief_description_of_branch].
  • I have added the major changes included in this pull request to the CHANGELOG.md under the next release version or unreleased, and updated the date.
  • All test cases passed locally.

@zhuchcn zhuchcn marked this pull request as ready for review October 23, 2023 17:28
@zhuchcn zhuchcn requested a review from lydiayliu October 23, 2023 17:28
@lydiayliu
Copy link
Collaborator

Adjacent variants were not merged as MNVs successfully. The function always exited with nothing.

None of them? XD Were the MNVs directly from VEP at least treated properly?

@zhuchcn
Copy link
Member Author

zhuchcn commented Oct 24, 2023

None of them? XD Were the MNVs directly from VEP at least treated properly?

Those are fine. Just the adjacent grouping wasn't done. I moved around the code block a couple of times and it must go wrong then. It was a bad decision not to have any test cases.

@zhuchcn
Copy link
Member Author

zhuchcn commented Nov 8, 2023

There might be still some inconsistency between mpg and bruteForce in turns of adjacent merged MNVs. I'll keep working on this but will merge it right now.

@zhuchcn zhuchcn closed this Nov 8, 2023
@zhuchcn zhuchcn reopened this Nov 8, 2023
@zhuchcn zhuchcn merged commit bb90867 into main Nov 8, 2023
4 checks passed
@zhuchcn zhuchcn deleted the czhu-fix-seqvar branch November 8, 2023 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants