Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VariantSourceSet Comparison Fixed #824

Merged
merged 1 commit into from
Nov 10, 2023
Merged

VariantSourceSet Comparison Fixed #824

merged 1 commit into from
Nov 10, 2023

Conversation

zhuchcn
Copy link
Member

@zhuchcn zhuchcn commented Nov 10, 2023

Description

VariantSourceSet comparison wasn't done correctly. The number of sources should not be checked any more, otherwise {'Noncoding', 'circRNA'} will always be larger than {'circRNA'}.

Closes #...

Checklist

  • This PR does NOT contain PHI or germline genetic data. A repo may need to be deleted if such data is uploaded. Disclosing PHI is a major problem.
  • This PR does NOT contain molecular files, compressed files, output files such as images (e.g. .png, .jpeg), .pdf, .RData, .xlsx, .doc, .ppt, or other non-plain-text files. To automatically exclude such files using a .gitignore file, see here for example.
  • I have read the code review guidelines and the code review best practice on GitHub check-list.
  • The name of the branch is meaningful and well formatted following the standards, using [AD_username (or 5 letters of AD if AD is too long)]-[brief_description_of_branch].
  • I have added the major changes included in this pull request to the CHANGELOG.md under the next release version or unreleased, and updated the date.
  • All test cases passed locally.

@zhuchcn zhuchcn requested a review from lydiayliu November 10, 2023 08:44
@zhuchcn zhuchcn marked this pull request as ready for review November 10, 2023 08:45
@lydiayliu
Copy link
Collaborator

I'm just gonna merge now to try this out!

@lydiayliu lydiayliu merged commit c3e0b66 into main Nov 10, 2023
2 checks passed
@lydiayliu lydiayliu deleted the czhu-fix-split-fasta branch November 10, 2023 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants