Fix mention input targetRange

udecode · Nov 19, 2023 · 3acfad9 · 3acfad9
1 parent 0389228
commit 3acfad9
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 5 deletions.
diff --git a/.changeset/blue-rules-attack.md b/.changeset/blue-rules-attack.md
@@ -0,0 +1,5 @@
+---
+'@udecode/plate-mention': patch
+---
+
+Fix combobox targetRange to account for normalization
diff --git a/packages/mention/src/withMention.ts b/packages/mention/src/withMention.ts
@@ -180,11 +180,16 @@ export const withMention = <
           focus: { path: operation.path.concat([0]), offset: text.length },
         });
 
-        comboboxActions.open({
-          activeId: id!,
-          text,
-          targetRange: editor.selection,
-        });
+        // Make sure that we read the updated selection after normalization.
+        // Slate may insert an empty text node before or after the mention input
+        // during normalization.
+        setTimeout(() => {
+          comboboxActions.open({
+            activeId: id!,
+            text,
+            targetRange: editor.selection,
+          });
+        }, 0);
       }
     } else if (
       operation.type === 'remove_node' &&