Merge pull request #3910 from udecode/improve-ts

chore: stricter typescript settings and some cleanup.
udecode · Dec 26, 2024 · 69f4f72 · 69f4f72
2 parents 63c4652 + c30304b
commit 69f4f72
Show file tree

Hide file tree

Showing 81 changed files with 41 additions and 132 deletions.
diff --git a/apps/www/tsconfig.json b/apps/www/tsconfig.json
@@ -1,17 +1,6 @@
 {
+  "extends": "../../tsconfig.json",
   "compilerOptions": {
-    "target": "es5",
-    "lib": ["dom", "dom.iterable", "esnext"],
-    "allowJs": true,
-    "skipLibCheck": true,
-    "strict": true,
-    "forceConsistentCasingInFileNames": true,
-    "noEmit": true,
-    "esModuleInterop": true,
-    "module": "esnext",
-    "moduleResolution": "Bundler",
-    "resolveJsonModule": true,
-    "isolatedModules": true,
     "jsx": "preserve",
     "incremental": true,
     "baseUrl": "src",
@@ -25,7 +14,6 @@
         "name": "next"
       }
     ],
-    "strictNullChecks": true
   },
   "include": [
     ".eslintrc.cjs",

diff --git a/apps/www/tsconfig.scripts.json b/apps/www/tsconfig.scripts.json
@@ -1,8 +1,6 @@
 {
-  "$schema": "https://json.schemastore.org/tsconfig",
   "extends": "./tsconfig.json",
   "compilerOptions": {
-    "target": "es6",
     "module": "ESNext",
     "moduleResolution": "node",
     "esModuleInterop": true,

diff --git a/packages/ai/src/lib/BaseAIPlugin.ts b/packages/ai/src/lib/BaseAIPlugin.ts
@@ -1,8 +1,8 @@
 import {
-  type OmitFirst,
-  type PluginConfig,
   bindFirst,
   createTSlatePlugin,
+  type OmitFirst,
+  type PluginConfig,
 } from '@udecode/plate-common';
 
 import { removeAIMarks, undoAI } from './transforms';

diff --git a/packages/ai/tsconfig.build.json b/packages/ai/tsconfig.build.json
@@ -1,7 +1,6 @@
 {
   "extends": "../../config/tsconfig.build.json",
   "compilerOptions": {
-    "declarationDir": "./dist",
     "outDir": "./dist"
   },
   "include": ["src"]

diff --git a/packages/alignment/tsconfig.build.json b/packages/alignment/tsconfig.build.json
@@ -1,7 +1,6 @@
 {
   "extends": "../../config/tsconfig.build.json",
   "compilerOptions": {
-    "declarationDir": "./dist",
     "outDir": "./dist"
   },
   "include": ["src"]

diff --git a/packages/autoformat/tsconfig.build.json b/packages/autoformat/tsconfig.build.json
@@ -1,7 +1,6 @@
 {
   "extends": "../../config/tsconfig.build.json",
   "compilerOptions": {
-    "declarationDir": "./dist",
     "outDir": "./dist"
   },
   "include": ["src"]

diff --git a/packages/basic-elements/tsconfig.build.json b/packages/basic-elements/tsconfig.build.json
@@ -1,7 +1,6 @@
 {
   "extends": "../../config/tsconfig.build.json",
   "compilerOptions": {
-    "declarationDir": "./dist",
     "outDir": "./dist"
   },
   "include": ["src"]

diff --git a/packages/basic-marks/tsconfig.build.json b/packages/basic-marks/tsconfig.build.json
@@ -1,7 +1,6 @@
 {
   "extends": "../../config/tsconfig.build.json",
   "compilerOptions": {
-    "declarationDir": "./dist",
     "outDir": "./dist"
   },
   "include": ["src"]

diff --git a/packages/block-quote/tsconfig.build.json b/packages/block-quote/tsconfig.build.json
@@ -1,7 +1,6 @@
 {
   "extends": "../../config/tsconfig.build.json",
   "compilerOptions": {
-    "declarationDir": "./dist",
     "outDir": "./dist"
   },
   "include": ["src"]

diff --git a/packages/break/tsconfig.build.json b/packages/break/tsconfig.build.json
@@ -1,7 +1,6 @@
 {
   "extends": "../../config/tsconfig.build.json",
   "compilerOptions": {
-    "declarationDir": "./dist",
     "outDir": "./dist"
   },
   "include": ["src"]

diff --git a/packages/callout/tsconfig.build.json b/packages/callout/tsconfig.build.json
@@ -1,7 +1,6 @@
 {
   "extends": "../../config/tsconfig.build.json",
   "compilerOptions": {
-    "declarationDir": "./dist",
     "outDir": "./dist"
   },
   "include": ["src"]

diff --git a/packages/callout/tsconfig.json b/packages/callout/tsconfig.json
@@ -1,7 +1,6 @@
 {
   "extends": "../../config/tsconfig.build.json",
   "compilerOptions": {
-    "declarationDir": "./dist",
     "outDir": "./dist"
   },
   "include": ["src"]

diff --git a/packages/caption/tsconfig.build.json b/packages/caption/tsconfig.build.json
@@ -1,7 +1,6 @@
 {
   "extends": "../../config/tsconfig.build.json",
   "compilerOptions": {
-    "declarationDir": "./dist",
     "outDir": "./dist"
   },
   "include": ["src"]

diff --git a/packages/cli/tsconfig.build.json b/packages/cli/tsconfig.build.json
@@ -1,7 +1,6 @@
 {
   "extends": "../../config/tsconfig.build.json",
   "compilerOptions": {
-    "declarationDir": "./dist",
     "outDir": "./dist"
   },
   "include": ["src"]

diff --git a/packages/cmdk/src/cmdk.tsx b/packages/cmdk/src/cmdk.tsx
@@ -246,7 +246,6 @@ const Command = React.forwardRef<HTMLDivElement, CommandProps>(
     const propsRef = useAsRef(props);
     const {
       children,
-      disablePointerSelection = false,
       filter,
       label,
       loop,
@@ -664,9 +663,9 @@ const Command = React.forwardRef<HTMLDivElement, CommandProps>(
         selectFirstItem,
         selectItem: updateSelectedToIndex,
         selectLastItem: last,
-        selectNextGroup: (e) => updateSelectedByGroup(1),
+        selectNextGroup: () => updateSelectedByGroup(1),
         selectNextItem: next,
-        selectPrevGroup: (e) => updateSelectedByGroup(-1),
+        selectPrevGroup: () => updateSelectedByGroup(-1),
         selectPrevItem: prev,
         setSearch,
       };

diff --git a/packages/cmdk/tsconfig.build.json b/packages/cmdk/tsconfig.build.json
@@ -1,7 +1,6 @@
 {
   "extends": "../../config/tsconfig.build.json",
   "compilerOptions": {
-    "declarationDir": "./dist",
     "outDir": "./dist"
   },
   "include": ["src"]

diff --git a/packages/cn/tsconfig.build.json b/packages/cn/tsconfig.build.json
@@ -1,7 +1,6 @@
 {
   "extends": "../../config/tsconfig.build.json",
   "compilerOptions": {
-    "declarationDir": "./dist",
     "outDir": "./dist"
   },
   "include": ["src"]

diff --git a/packages/code-block/tsconfig.build.json b/packages/code-block/tsconfig.build.json
@@ -1,7 +1,6 @@
 {
   "extends": "../../config/tsconfig.build.json",
   "compilerOptions": {
-    "declarationDir": "./dist",
     "outDir": "./dist"
   },
   "include": ["src"]

diff --git a/packages/combobox/tsconfig.build.json b/packages/combobox/tsconfig.build.json
@@ -1,7 +1,6 @@
 {
   "extends": "../../config/tsconfig.build.json",
   "compilerOptions": {
-    "declarationDir": "./dist",
     "outDir": "./dist"
   },
   "include": ["src"]

diff --git a/packages/comments/tsconfig.build.json b/packages/comments/tsconfig.build.json
@@ -1,7 +1,6 @@
 {
   "extends": "../../config/tsconfig.build.json",
   "compilerOptions": {
-    "declarationDir": "./dist",
     "outDir": "./dist"
   },
   "include": ["src"]

diff --git a/packages/common/tsconfig.build.json b/packages/common/tsconfig.build.json
@@ -1,7 +1,6 @@
 {
   "extends": "../../config/tsconfig.build.json",
   "compilerOptions": {
-    "declarationDir": "./dist",
     "outDir": "./dist"
   },
   "include": ["src"]

diff --git a/packages/core/src/lib/plugins/getCorePlugins.ts b/packages/core/src/lib/plugins/getCorePlugins.ts
@@ -1,28 +1,16 @@
 import type { AnyPluginConfig, PluginConfig } from '../plugin/BasePlugin';
 import type { SlatePlugin } from '../plugin/SlatePlugin';
-
-import {
-  createSlatePlugin,
-  createTSlatePlugin,
-} from '../plugin/createSlatePlugin';
 import { AstPlugin } from './AstPlugin';
 import { DOMPlugin } from './DOMPlugin';
 import { HistoryPlugin } from './HistoryPlugin';
 import { InlineVoidPlugin } from './InlineVoidPlugin';
 import { ParserPlugin } from './ParserPlugin';
-import { type DebugErrorType, type LogLevel, DebugPlugin } from './debug';
+import { type DebugErrorType, DebugPlugin, type LogLevel } from './debug';
 import { SlateNextPlugin } from './editor-protocol';
 import { HtmlPlugin } from './html';
 import { LengthPlugin } from './length';
 import { BaseParagraphPlugin } from './paragraph';
 
-// Somehow needed to avoid cyclic dependency
-// eslint-disable-next-line @typescript-eslint/no-unused-vars
-const _ = () => {
-  createSlatePlugin();
-  createTSlatePlugin();
-};
-
 export type CorePlugin = ReturnType<typeof getCorePlugins>[number];
 
 export type GetCorePluginsOptions = {

diff --git a/packages/core/src/lib/static/utils/stripHtmlClassNames.ts b/packages/core/src/lib/static/utils/stripHtmlClassNames.ts
@@ -23,9 +23,8 @@ export const stripHtmlClassNames = (
         .split(/\s+/)
         .filter((cn) => preserveRegExp.test(cn));
 
-      return classesToKeep.length === 0
-        ? ''
-        : ` class="${classesToKeep.join(' ')}"`;
-    }
-  );
+    return classesToKeep.length === 0
+      ? ''
+      : ` class="${classesToKeep.join(' ')}"`;
+  });
 };
diff --git a/packages/core/src/react/components/PlateControllerEffect.ts b/packages/core/src/react/components/PlateControllerEffect.ts
@@ -10,6 +10,8 @@ import {
   usePlateSelectors,
   usePlateStore,
 } from '../stores';
+import type { WritableAtom } from 'jotai/vanilla/atom';
+import type { JotaiStore } from 'jotai-x';
 
 export interface PlateControllerEffectProps {
   id?: string;
@@ -23,8 +25,13 @@ export const PlateControllerEffect = ({
 
   const currentStoreAtom = React.useMemo(
     () =>
-      focusAtom(plateControllerStore.atom.editorStores, (optic) =>
-        optic.prop(id)
+      focusAtom(
+        plateControllerStore.atom.editorStores as WritableAtom<
+          Record<string, JotaiStore | null>,
+          any,
+          any
+        >,
+        (optic) => optic.prop(id)
       ),
     [id]
   );

diff --git a/packages/core/src/react/stores/plate-controller/plateControllerStore.ts b/packages/core/src/react/stores/plate-controller/plateControllerStore.ts
@@ -12,9 +12,9 @@ export const {
   usePlateControllerStore,
 } = createAtomStore(
   {
-    activeId: atom(null as string | null),
-    editorStores: atom({} as Record<string, JotaiStore | null>),
-    primaryEditorIds: atom([] as string[]),
+    activeId: atom<string | null>(null),
+    editorStores: atom<Record<string, JotaiStore | null>>({}),
+    primaryEditorIds: atom<string[]>([]),
   },
   {
     name: 'plateController',

diff --git a/packages/core/tsconfig.build.json b/packages/core/tsconfig.build.json
@@ -1,7 +1,6 @@
 {
   "extends": "../../config/tsconfig.build.json",
   "compilerOptions": {
-    "declarationDir": "./dist",
     "outDir": "./dist"
   },
   "include": ["src"]

diff --git a/packages/csv/tsconfig.build.json b/packages/csv/tsconfig.build.json
@@ -1,7 +1,6 @@
 {
   "extends": "../../config/tsconfig.build.json",
   "compilerOptions": {
-    "declarationDir": "./dist",
     "outDir": "./dist"
   },
   "include": ["src"]

diff --git a/packages/cursor/tsconfig.build.json b/packages/cursor/tsconfig.build.json
@@ -1,7 +1,6 @@
 {
   "extends": "../../config/tsconfig.build.json",
   "compilerOptions": {
-    "declarationDir": "./dist",
     "outDir": "./dist"
   },
   "include": ["src"]

diff --git a/packages/date/tsconfig.build.json b/packages/date/tsconfig.build.json
@@ -1,7 +1,6 @@
 {
   "extends": "../../config/tsconfig.build.json",
   "compilerOptions": {
-    "declarationDir": "./dist",
     "outDir": "./dist"
   },
   "include": ["src"]

diff --git a/packages/diff/tsconfig.build.json b/packages/diff/tsconfig.build.json
@@ -1,7 +1,6 @@
 {
   "extends": "../../config/tsconfig.build.json",
   "compilerOptions": {
-    "declarationDir": "./dist",
     "outDir": "./dist"
   },
   "include": ["src"]

diff --git a/packages/dnd/tsconfig.build.json b/packages/dnd/tsconfig.build.json
@@ -1,7 +1,6 @@
 {
   "extends": "../../config/tsconfig.build.json",
   "compilerOptions": {
-    "declarationDir": "./dist",
     "outDir": "./dist"
   },
   "include": ["src"]

diff --git a/packages/docx/tsconfig.build.json b/packages/docx/tsconfig.build.json
@@ -1,7 +1,6 @@
 {
   "extends": "../../config/tsconfig.build.json",
   "compilerOptions": {
-    "declarationDir": "./dist",
     "outDir": "./dist"
   },
   "include": ["src"]

diff --git a/packages/emoji/tsconfig.build.json b/packages/emoji/tsconfig.build.json
@@ -1,7 +1,6 @@
 {
   "extends": "../../config/tsconfig.build.json",
   "compilerOptions": {
-    "declarationDir": "./dist",
     "outDir": "./dist"
   },
   "include": ["src"]

diff --git a/packages/excalidraw/tsconfig.build.json b/packages/excalidraw/tsconfig.build.json
@@ -1,7 +1,6 @@
 {
   "extends": "../../config/tsconfig.build.json",
   "compilerOptions": {
-    "declarationDir": "./dist",
     "outDir": "./dist"
   },
   "include": ["src"]

diff --git a/packages/find-replace/tsconfig.build.json b/packages/find-replace/tsconfig.build.json
@@ -1,7 +1,6 @@
 {
   "extends": "../../config/tsconfig.build.json",
   "compilerOptions": {
-    "declarationDir": "./dist",
     "outDir": "./dist"
   },
   "include": ["src"]

diff --git a/packages/floating/tsconfig.build.json b/packages/floating/tsconfig.build.json
@@ -1,7 +1,6 @@
 {
   "extends": "../../config/tsconfig.build.json",
   "compilerOptions": {
-    "declarationDir": "./dist",
     "outDir": "./dist"
   },
   "include": ["src"]

diff --git a/packages/font/tsconfig.build.json b/packages/font/tsconfig.build.json
@@ -1,7 +1,6 @@
 {
   "extends": "../../config/tsconfig.build.json",
   "compilerOptions": {
-    "declarationDir": "./dist",
     "outDir": "./dist"
   },
   "include": ["src"]

diff --git a/packages/heading/tsconfig.build.json b/packages/heading/tsconfig.build.json
@@ -1,7 +1,6 @@
 {
   "extends": "../../config/tsconfig.build.json",
   "compilerOptions": {
-    "declarationDir": "./dist",
     "outDir": "./dist"
   },
   "include": ["src"]

diff --git a/packages/highlight/tsconfig.build.json b/packages/highlight/tsconfig.build.json
@@ -1,7 +1,6 @@
 {
   "extends": "../../config/tsconfig.build.json",
   "compilerOptions": {
-    "declarationDir": "./dist",
     "outDir": "./dist"
   },
   "include": ["src"]