review changes

udecode · Oct 9, 2023 · 7563206 · 7563206
1 parent cc83703
commit 7563206
Show file tree

Hide file tree

Showing 6 changed files with 11 additions and 24 deletions.
diff --git a/apps/www/src/config/customizer-items.ts b/apps/www/src/config/customizer-items.ts
@@ -959,20 +959,10 @@ export const customizerItems: Record<string, SettingPlugin> = {
   },
   [KEY_DELETE]: {
     id: KEY_DELETE,
-    npmPackage: '@udecode/plate-select',
+    npmPackage: '@udecode/plate-delete',
     pluginFactory: 'createDeletePlugin',
-    pluginOptions: [
-      `options: {`,
-      `  query: {`,
-      `    allow: [`,
-      `      // ELEMENT_IMAGE, ELEMENT_HR`,
-      `    ],`,
-      `  },`,
-      `},`,
-    ],
-    label: 'Forward Delete Plugin',
+    label: 'Delete',
     badges: [customizerBadges.handler],
-    route: customizerPlugins.media.route,
   },
   [KEY_SINGLE_LINE]: {
     id: KEY_SINGLE_LINE,

diff --git a/apps/www/src/config/descriptions.ts b/apps/www/src/config/descriptions.ts
@@ -94,7 +94,7 @@ export const descriptions: Record<string, string> = {
   [KEY_RESET_NODE]: 'Reset the block type using rules.',
   [KEY_SELECT_ON_BACKSPACE]:
     'Select the preceding block instead of deleting when pressing backspace.',
-  [KEY_DELETE]: 'Enable forward delete plugin',
+  [KEY_DELETE]: 'Remove the current block if empty when pressing delete foward',
   [KEY_SINGLE_LINE]: 'Restrict the editor to a single block.',
   [KEY_SOFT_BREAK]:
     'Insert line breaks within a block of text without starting a new block.',

diff --git a/apps/www/src/registry/default/example/playground-demo.tsx b/apps/www/src/registry/default/example/playground-demo.tsx
@@ -220,7 +220,7 @@ export const usePlaygroundPlugins = ({
             enabled: !!enabled.selectOnBackspace,
           }),
           createDeletePlugin({
-            enabled: !!enabled.selectOnBackspace,
+            enabled: !!enabled.createDeletePlugin,
           }),
           createSingleLinePlugin({
             enabled: id === 'singleline' || !!enabled.singleLine,

diff --git a/packages/select/src/createDeletePlugin.ts b/packages/select/src/createDeletePlugin.ts
@@ -1,4 +1,4 @@
-import { createPluginFactory, QueryNodeOptions } from '@udecode/plate-common';
+import { createPluginFactory, ELEMENT_DEFAULT, QueryNodeOptions } from '@udecode/plate-common';
 
 import { withDelete } from './withDelete';
 
@@ -14,4 +14,9 @@ export const KEY_DELETE = 'delete';
 export const createDeletePlugin = createPluginFactory<DeletePlugin>({
   key: KEY_DELETE,
   withOverrides: withDelete,
+  options: {
+    query: {
+      allow: [ELEMENT_DEFAULT],
+    },
+  },
 });
diff --git a/packages/select/src/withDelete.ts b/packages/select/src/withDelete.ts
@@ -22,7 +22,7 @@ export const withDelete = <
   { options: { query } }: WithPlatePlugin<DeletePlugin, V, E>
 ) => {
   const { deleteForward } = editor;
-  editor.deleteForward = (unit: 'character' | 'word' | 'line' | 'block') => {
+  editor.deleteForward = (unit) => {
     if (!editor.selection) return;
     const isValidNode = queryNode(getAboveNode(editor), query);
     if (

diff --git a/templates/plate-playground-template/src/lib/plate/plate-plugins.ts b/templates/plate-playground-template/src/lib/plate/plate-plugins.ts
@@ -38,7 +38,6 @@ import { createComboboxPlugin } from '@udecode/plate-combobox';
 import { createCommentsPlugin, MARK_COMMENT } from '@udecode/plate-comments';
 import {
   createPlugins,
-  ELEMENT_DEFAULT,
   isBlockAboveEmpty,
   isSelectionAtBlockStart,
   PlateElement,
@@ -324,13 +323,6 @@ export const plugins = createPlugins(
       },
     }),
 
-    createDeletePlugin({
-      options: {
-        query: {
-          allow: [ELEMENT_DEFAULT],
-        },
-      },
-    }),
     createSoftBreakPlugin({
       options: {
         rules: [