Merge pull request #2797 from udecode/fix/serialize-html-26-bug

Fix: `serializeHtml` mutates the live `editor` instance
udecode · Dec 9, 2023 · a19f76f · a19f76f
2 parents b807c40 + 61c08d5
commit a19f76f
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/.changeset/silver-rings-own.md b/.changeset/silver-rings-own.md
@@ -0,0 +1,5 @@
+---
+'@udecode/plate-serializer-html': patch
+---
+
+Fix: `serializeHtml` mutates the live `editor` instance
diff --git a/packages/serializer-html/src/elementToHtml.ts b/packages/serializer-html/src/elementToHtml.ts
@@ -50,7 +50,6 @@ export const elementToHtml = <V extends Value>(
       renderToStaticMarkup(
         createElementWithSlate(
           {
-            editor: editor as any,
             ...plateProps,
             children:
               plugin.serializeHtml?.(props as any) ??

diff --git a/packages/serializer-html/src/utils/createElementWithSlate.ts b/packages/serializer-html/src/utils/createElementWithSlate.ts
@@ -1,5 +1,5 @@
 import React, { ComponentClass, FunctionComponent } from 'react';
-import { Plate, PlateProps } from '@udecode/plate-common';
+import { createPlateEditor, Plate, PlateProps } from '@udecode/plate-common';
 
 /**
  * Create a React element wrapped in a Plate provider.
@@ -9,7 +9,7 @@ export const createElementWithSlate = (
   dndWrapper?: string | FunctionComponent | ComponentClass
 ) => {
   const {
-    editor,
+    editor = createPlateEditor(),
     value = [],
     onChange = () => {},
     children,