Merge pull request #3796 from siosio34/main

fix: parseTwitterUrl logic
udecode · Nov 21, 2024 · af9679b · af9679b
2 parents 4d3e452 + 3e7b342
commit af9679b
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/.changeset/clean-cups-sort.md b/.changeset/clean-cups-sort.md
@@ -0,0 +1,5 @@
+---
+"@udecode/plate-media": patch
+---
+
+fix: `parseTwitterUrl`
diff --git a/packages/media/src/lib/media-embed/parseTwitterUrl.ts b/packages/media/src/lib/media-embed/parseTwitterUrl.ts
@@ -3,12 +3,15 @@ import type { EmbedUrlData } from '../media/parseMediaUrl';
 const twitterRegex =
   /^https?:\/\/(?:twitter|x)\.com\/(?:#!\/)?(\w+)\/status(es)?\/(\d+)/;
 
+const TWITTER_ID_INDEX = 3
+
 export const parseTwitterUrl = (url: string): EmbedUrlData | undefined => {
-  if (twitterRegex.exec(url)) {
+  const match = twitterRegex.exec(url);
+  if (match) {
     return {
-      id: twitterRegex.exec(url)?.groups?.id,
+      id: match[TWITTER_ID_INDEX],
       provider: 'twitter',
       url,
     };
   }
-};
+};