Fix: Plate ignores plugins passed via editor

udecode · Dec 22, 2023 · c0f7c59 · c0f7c59
1 parent f8fd55f
commit c0f7c59
Show file tree

Hide file tree

Showing 3 changed files with 26 additions and 2 deletions.
diff --git a/.changeset/chilled-ligers-jam.md b/.changeset/chilled-ligers-jam.md
@@ -2,4 +2,5 @@
 '@udecode/plate-core': patch
 ---
 
-Fix: `readOnly` on Plate store defaults to false and overrides `readOnly` on PlateContent
+- Fix: `readOnly` on Plate store defaults to false and overrides `readOnly` on PlateContent
+- Fix: Plate ignores plugins passed via `editor`
diff --git a/packages/core/src/components/Plate.spec.tsx b/packages/core/src/components/Plate.spec.tsx
@@ -132,6 +132,28 @@ describe('Plate', () => {
         expect(result.current.at(-1)!.key).toBe('test2');
       });
     });
+
+    it('should use plugins from editor', () => {
+      const _plugins = [{ key: 'test' }];
+      const editor = createPlateEditor({ plugins: _plugins });
+
+      const wrapper = ({ children }: any) => (
+        <Plate editor={editor}>{children}</Plate>
+      );
+
+      const { result, rerender } = renderHook(
+        () => usePlateSelectors().plugins(),
+        {
+          wrapper,
+        }
+      );
+
+      expect(result.current.some((p: any) => p.key === 'test')).toBe(true);
+
+      rerender();
+
+      expect(result.current.some((p: any) => p.key === 'test')).toBe(true);
+    });
   });
 
   describe('when id updates', () => {

diff --git a/packages/core/src/hooks/usePlateEffects.ts b/packages/core/src/hooks/usePlateEffects.ts
@@ -1,5 +1,6 @@
 import { useEffect } from 'react';
 import { Value } from '@udecode/slate';
+import { isDefined } from '@udecode/utils';
 
 import { PlateProps } from '../components';
 import { useEditorRef, usePlateStates } from '../stores';
@@ -26,7 +27,7 @@ export const usePlateEffects = <
   const [, setPlugins] = states.plugins();
 
   useEffect(() => {
-    if (pluginsProp !== rawPlugins) {
+    if (isDefined(pluginsProp) && pluginsProp !== rawPlugins) {
       setRawPlugins(rawPlugins);
 
       setPlatePlugins<V, E>(editor, {