Merge branch 'main' into docs/upload

udecode · Nov 17, 2024 · ca70f4a · ca70f4a
2 parents c68f868 + a12690a
commit ca70f4a
Showing 1 changed file with 22 additions and 13 deletions.
diff --git a/apps/www/src/registry/default/plate-ui/media-toolbar-button.tsx b/apps/www/src/registry/default/plate-ui/media-toolbar-button.tsx
@@ -1,12 +1,12 @@
 'use client';
 
-import React, { useCallback, useEffect, useState } from 'react';
+import React, { useCallback, useState } from 'react';
 
 import type { DropdownMenuProps } from '@radix-ui/react-dropdown-menu';
 
 import { cn } from '@udecode/cn';
-import { insertNodes } from '@udecode/plate-common';
-import { focusEditor, useEditorRef } from '@udecode/plate-common/react';
+import { insertNodes, isUrl } from '@udecode/plate-common';
+import { useEditorRef } from '@udecode/plate-core/react';
 import {
   AudioPlugin,
   FilePlugin,
@@ -20,6 +20,7 @@ import {
   ImageIcon,
   LinkIcon,
 } from 'lucide-react';
+import { toast } from 'sonner';
 import { useFilePicker } from 'use-file-picker';
 
 import {
@@ -104,21 +105,16 @@ export function MediaToolbarButton({
   const [url, setUrl] = useState('');
 
   const embedMedia = useCallback(() => {
+    if (!isUrl(url)) return toast.error('Invalid URL');
+
     setDialogOpen(false);
     insertNodes(editor, {
       children: [{ text: '' }],
       name: nodeType === FilePlugin.key ? url.split('/').pop() : undefined,
       type: nodeType,
       url,
     });
-  }, [editor, nodeType, url]);
-
-  useEffect(() => {
-    if (!dialogOpen) {
-      focusEditor(editor);
-      setUrl('');
-    }
-  }, [dialogOpen, editor]);
+  }, [url, editor, nodeType]);
 
   return (
     <>
@@ -166,7 +162,13 @@ export function MediaToolbarButton({
         </DropdownMenuContent>
       </DropdownMenu>
 
-      <AlertDialog open={dialogOpen} onOpenChange={setDialogOpen}>
+      <AlertDialog
+        open={dialogOpen}
+        onOpenChange={(value) => {
+          setDialogOpen(value);
+          setUrl('');
+        }}
+      >
         <AlertDialogContent>
           <AlertDialogHeader>
             <AlertDialogTitle>{currentConfig.title}</AlertDialogTitle>
@@ -192,7 +194,14 @@ export function MediaToolbarButton({
           </AlertDialogHeader>
           <AlertDialogFooter>
             <AlertDialogCancel>Cancel</AlertDialogCancel>
-            <AlertDialogAction onClick={embedMedia}>Accept</AlertDialogAction>
+            <AlertDialogAction
+              onClick={(e) => {
+                e.preventDefault();
+                embedMedia();
+              }}
+            >
+              Accept
+            </AlertDialogAction>
           </AlertDialogFooter>
         </AlertDialogContent>
       </AlertDialog>