remove default conditoin and update conditions as queryNode return tr…

…ue when query is undefined
udecode · Oct 9, 2023 · dffc3d7 · dffc3d7
1 parent 98de45f
commit dffc3d7
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 31 deletions.
diff --git a/apps/www/src/lib/plate/demo/plugins/deletePlugin.ts b/apps/www/src/lib/plate/demo/plugins/deletePlugin.ts
diff --git a/apps/www/src/registry/default/example/playground-demo.tsx b/apps/www/src/registry/default/example/playground-demo.tsx
@@ -92,7 +92,6 @@ import { HTML5Backend } from 'react-dnd-html5-backend';
 
 import { ValueId } from '@/config/customizer-plugins';
 import { captionPlugin } from '@/lib/plate/demo/plugins/captionPlugin';
-import { deletePlugin } from '@/lib/plate/demo/plugins/deletePlugin';
 import { cn } from '@/lib/utils';
 import { settingsStore } from '@/components/context/settings-store';
 import { PlaygroundFixedToolbarButtons } from '@/components/plate-ui/playground-fixed-toolbar-buttons';
@@ -221,7 +220,6 @@ export const usePlaygroundPlugins = ({
             enabled: !!enabled.selectOnBackspace,
           }),
           createDeletePlugin({
-            ...deletePlugin,
             enabled: !!enabled.selectOnBackspace,
           }),
           createSingleLinePlugin({

diff --git a/packages/select/src/withDelete.ts b/packages/select/src/withDelete.ts
@@ -24,24 +24,16 @@ export const withDelete = <
   const { deleteForward } = editor;
   editor.deleteForward = (unit: 'character' | 'word' | 'line' | 'block') => {
     if (!editor.selection) return;
-    if (!isSelectionExpanded(editor) && isBlockAboveEmpty(editor)) {
-      // check when line is empty
-      const isValidNode = queryNode(getAboveNode(editor), query);
-      if (query) {
-        //is query is passed
-        if (isValidNode) {
-          // cursor is in query blocks
-          removeNodes(editor as any);
-        } else {
-          //fallback to default behaiour
-          deleteForward(unit);
-        }
-      } else {
-        // query is not passed, then plugin is active everywhere
-        removeNodes(editor as any);
-      }
+    const isValidNode = queryNode(getAboveNode(editor), query);
+    if (
+      !isSelectionExpanded(editor) &&
+      isBlockAboveEmpty(editor) &&
+      isValidNode
+    ) {
+      // Cursor is in query blocks and line is empty
+      removeNodes(editor as any);
     } else {
-      // when line is not empty, fall back to default behavior
+      // When the line is not empty or other conditions are not met, fall back to default behavior
       deleteForward(unit);
     }
   };

diff --git a/packages/serializer-docx/src/docx-cleaner/utils/cleanDocxImageElements.ts b/packages/serializer-docx/src/docx-cleaner/utils/cleanDocxImageElements.ts
@@ -30,7 +30,10 @@ export const cleanDocxImageElements = (
 
       const alt = element.getAttribute('alt');
 
-      if (typeof alt === 'string' && validator.isURL(alt, { require_protocol: true })) {
+      if (
+        typeof alt === 'string' &&
+        validator.isURL(alt, { require_protocol: true })
+      ) {
         element.setAttribute('src', alt);
         return true;
       }