Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace rollup by tsup as building tool #2627

Closed
zbeyens opened this issue Sep 15, 2023 · 13 comments
Closed

Replace rollup by tsup as building tool #2627

zbeyens opened this issue Sep 15, 2023 · 13 comments

Comments

@zbeyens
Copy link
Member

zbeyens commented Sep 15, 2023

Description

The current project utilizes Rollup as the building tool, but we would like to replace it with Tsup for better performance and additional features. This issue aims to implement the necessary changes to switch from Rollup to Tsup seamlessly.

Expected Specifications:

  1. In the root package, update the p:build scripts to use Tsup instead of Rollup.
  2. In the root package, update the p:build:watch script to use Tsup with the --watch flag for automatic rebuilds on file changes.
  3. In the root package, update g:build:watch to build and watch all packages concurrently (using turbo).
  4. Enable hot reloading for the Next.js app www when changes occur in any file in packages, using transpilePackages. Currently, with Rollup, a restart is necessary. Modify the configuration to support hot reloading seamlessly. This is the main goal of that issue.
  5. Ensure there are no regressions from the current Rollup configuration. The project should build and run without any issues and produce the same expected output as it does with Rollup. We will do a test release to confirm that one.

Concurrent attempts are accepted until the first PR lands.

Funding

  • You can sponsor this specific effort via a Polar.sh pledge below
  • We receive the pledge once the issue is completed & verified
Fund with Polar
@zbeyens zbeyens added bug Something isn't working build and removed bug Something isn't working labels Sep 15, 2023
@zbeyens
Copy link
Member Author

zbeyens commented Sep 15, 2023

/bounty $200

@algora-pbc
Copy link

algora-pbc bot commented Sep 15, 2023

💎 $200 bounty created by zbeyens
🙋 If you start working on this, comment /attempt #2627 to notify everyone
👉 To claim this bounty, submit a pull request that includes the text /claim #2627 somewhere in its body
📝 Before proceeding, please make sure you can receive payouts in your country
💵 Payment arrives in your account 2-5 days after the bounty is rewarded
💯 You keep 100% of the bounty award
🙏 Thank you for contributing to udecode/plate!

Attempt Started (GMT+0) Solution
🔴 @rishi-raj-jain Sep 15, 2023, 9:43:33 AM WIP
🟢 @AFZL210 Sep 15, 2023, 1:20:15 PM WIP
🟢 @g1mishra Sep 17, 2023, 8:13:09 PM WIP
🟢 @shahriar-shojib #2652

@zbeyens zbeyens changed the title Replace rollup build by tsup as building tool Replace rollup by tsup as building tool Sep 15, 2023
@rishi-raj-jain
Copy link
Contributor

rishi-raj-jain commented Sep 15, 2023

/attempt #2627

Options

@rishi-raj-jain
Copy link
Contributor

@zbeyens Right now yarn p:rollup fails because src/index.tsx doesn't exist. Can you help me there?

@rishi-raj-jain
Copy link
Contributor

Screenshot 2023-09-15 at 3 36 11 PM

@zbeyens
Copy link
Member Author

zbeyens commented Sep 15, 2023

This command should be run in a package (hence p:), not the root one.

@rishi-raj-jain
Copy link
Contributor

ah I see, my bad just realized that

@AFZL210
Copy link

AFZL210 commented Sep 15, 2023

/attempt #2627

Options

@algora-pbc
Copy link

algora-pbc bot commented Sep 15, 2023

Note: The user @rishi-raj-jain is already attempting to complete issue #2627 and claim the bounty. If you attempt to complete the same issue, there is a chance that @rishi-raj-jain will complete the issue first, and be awarded the bounty. We recommend discussing with @rishi-raj-jain and potentially collaborating on the same solution versus creating an alternate solution.

@g1mishra
Copy link

g1mishra commented Sep 17, 2023

/attempt #2627

Options

@algora-pbc
Copy link

algora-pbc bot commented Sep 17, 2023

Note: The user @AFZL210 is already attempting to complete issue #2627 and claim the bounty. If you attempt to complete the same issue, there is a chance that @AFZL210 will complete the issue first, and be awarded the bounty. We recommend discussing with @AFZL210 and potentially collaborating on the same solution versus creating an alternate solution.

@algora-pbc
Copy link

algora-pbc bot commented Sep 28, 2023

💡 @shahriar-shojib submitted a pull request that claims the bounty. You can visit your org dashboard to reward.
👉 @shahriar-shojib: To receive payouts, sign up on Algora, link your Github account and connect with Stripe on your dashboard.

@algora-pbc
Copy link

algora-pbc bot commented Sep 30, 2023

🎉🎈 @shahriar-shojib has been awarded $200! 🎈🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants