convert to tsup #2652

shahriar-shojib · 2023-09-28T11:29:07Z

Description
implements #2627

checklist:

migrate to tsup
make sure packages can be watched
make sure nextjs hot reloads if a package is changed
keep bundle format as it was on rollup
deployments passing
tests passing
test for @swc/core regressions
performant watching of all packages

/claim #2627

keeping this as draft so that I can run some tests

See changesets.

changeset-bot · 2023-09-28T11:29:10Z

🦋 Changeset detected

Latest commit: a0d56f4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 56 packages

Name	Type
@udecode/plate-alignment	Minor
@udecode/plate-autoformat	Minor
@udecode/plate-basic-elements	Minor
@udecode/plate-basic-marks	Minor
@udecode/plate-block-quote	Minor
@udecode/plate-break	Minor
@udecode/plate-caption	Minor
@udecode/plate-ui	Minor
@udecode/plate-cloud	Minor
@udecode/plate-code-block	Minor
@udecode/plate-combobox	Minor
@udecode/plate-comments	Minor
@udecode/plate-common	Minor
@udecode/plate-core	Minor
@udecode/plate-cursor	Minor
@udecode/plate-dnd	Minor
@udecode/plate-emoji	Minor
@udecode/plate-excalidraw	Minor
@udecode/plate-find-replace	Minor
@udecode/plate-floating	Minor
@udecode/plate-font	Minor
@udecode/plate-heading	Minor
@udecode/plate-highlight	Minor
@udecode/plate-horizontal-rule	Minor
@udecode/plate-indent	Minor
@udecode/plate-indent-list	Minor
@udecode/plate-juice	Minor
@udecode/plate-kbd	Minor
@udecode/plate-line-height	Minor
@udecode/plate-link	Minor
@udecode/plate-list	Minor
@udecode/plate-media	Minor
@udecode/plate-mention	Minor
@udecode/plate-node-id	Minor
@udecode/plate-normalizers	Minor
@udecode/plate-paragraph	Minor
@udecode/plate	Minor
@udecode/plate-utils	Minor
@udecode/plate-reset-node	Minor
@udecode/plate-resizable	Minor
@udecode/plate-select	Minor
@udecode/plate-selection	Minor
@udecode/plate-serializer-csv	Minor
@udecode/plate-serializer-docx	Minor
@udecode/plate-serializer-html	Minor
@udecode/plate-serializer-md	Minor
@udecode/slate	Minor
@udecode/slate-react	Minor
@udecode/slate-utils	Minor
@udecode/plate-suggestion	Minor
@udecode/plate-tabbable	Minor
@udecode/plate-table	Minor
@udecode/plate-test-utils	Minor
@udecode/plate-trailing-block	Minor
@udecode/utils	Minor
@udecode/plate-yjs	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel · 2023-09-28T11:29:11Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
plate	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 30, 2023 2:58pm

reviewpad · 2023-09-28T11:29:16Z

Thank you @shahriar-shojib for this first contribution!

config/tsup.config.ts

rishi-raj-jain · 2023-09-28T11:34:07Z

config/tsup.config.ts

+  cjsInterop: true,
+  dts: true,
+  replaceNodeEnv: true,
+  skipNodeModulesBundle: true,


Why is this required?

this will skip bundling of anything imported that is not local to the package even if it is a dependency.
Ideally, for packages like these, I think it's best not to bundle node_module packages in the build files since it will be taken care of by the end user's bundler.
Since we're not shipping browser bundles this provides some safety in my opinion.
If you think this is unnecessary I can remove it

We will test it on next release

config/tsup.config.ts

shahriar-shojib · 2023-09-28T11:42:42Z

I am not sure why the preview builds are failing, and I am unable to check the vercel logs.

shahriar-shojib · 2023-09-28T11:57:33Z

I am unsure if tailwind, babel, and JSON to esmodule support are necessary for the builds.
As I understand, these things are required by the plateUI components and those are no longer packaged up.

zbeyens · 2023-09-28T12:44:08Z

Tailwind and json are not. If there is no regression without Babel, we could proceed without it. Note that yarn test should still work.

The CI that is failing is yarn build && yarn workspace www build which you can run locally.

shahriar-shojib · 2023-09-28T16:31:22Z

I was able to run the test locally and it passed, CI logs are not showing why exactly the tests are failing, I will dig into it.
As for yarn workspace www build it also completes locally without any issues.

Could I get some logs from Vercel, please?

zbeyens · 2023-09-28T16:38:43Z

I think the reason why it works locally is that you already have a build somehow. Try to run yarn g:clean.

shahriar-shojib · 2023-09-28T17:36:16Z

I ran all of the commands using --force to bypass turbo cache all of them succeeded on local, I ran yarn g:clean before running these.
I am currently checking if there's any cache at play here that's causing the tests to fail on CI.

shahriar-shojib · 2023-09-28T20:11:12Z

ok so, I was able to get it run completely after adjusting a few values on concurrency, it was timing out on my repo.

Here's what I suspect is going on:

I think turbo runs tasks with parallel task count equal to host logical cores, and jest runs tests in parallel which equals to host logical CPU count too.

I have some further adjustments to make to make sure we're using the system to its fullest potential.

Also, what are your thoughts on using @swc/jest ?
I changed the jest transformer from ts-jest to @swc/jest on local and saw a massive improvement in test duration.
if you want I can make the necessary changes and push it, as per my early testing, all tests seem to run and pass.
Since we have a typecheck step in CI I think not checking the types for tests will be a big issue.

my test run: https://github.com/shahriar-shojib/plate/actions/runs/6343411359

shahriar-shojib · 2023-09-28T20:13:04Z

as for vercel deployment I am unable to figure out why it's failing, as you can see from the CI outputs it does not fail at the build step.

zbeyens · 2023-09-28T21:35:17Z

Thanks for suggesting @swc/jest, tests were a bit slow so let's use it.

As for Vercel, there is no error except

It's probably a concurrency issue. Could you try using https://vercel.com/docs/cli/build locally?

switch to @swc/core nextjs conditional config revert ci edits

zbeyens · 2023-09-30T10:15:56Z

@shahriar-shojib Could we use https://github.com/gajus/turbowatch? Ref: vercel/turborepo#986 (comment)

zbeyens · 2023-09-30T10:57:23Z

I have fixed the is-hotkey bug. Please rebase on same branch.

shahriar-shojib · 2023-09-30T11:04:11Z

This looks nice, but I just added turbowatch and moved build:watch to use turbowatch

shahriar-shojib · 2023-09-30T11:05:49Z

please let me know if you need to build the dependents of a changed package

zbeyens · 2023-09-30T11:28:31Z

Excellent job, thanks! Turbowatch is doing exactly what we needed so you can remove tsx package and config/dev-packages.ts. Also, you can revert the AnyObject changes. Once done, I'll merge this and do a test release. Then we can test it out on templates/plate-playground.

As for building dependents, it's just about running yarn build in onChange: turbo caching system takes care of the rest. But let's keep what you did as I'm not sure we need to build the dependents since the packages are symlinked.

shahriar-shojib · 2023-09-30T14:13:04Z

I am getting this error when removing the type parameter.

convert AnyObject from interface to type convert TElement from interface to type convert TTest from interface to type remove tsx package & dev script

shahriar-shojib · 2023-09-30T14:30:03Z

I fixed this by converting AnyObject, TElement, TTest from interface to type.

Should not cause any breaking changees.

packages/core/src/types/plugin/PlatePlugin.ts

packages/core/src/utils/pluginInjectProps.ts

shahriar-shojib · 2023-09-30T16:59:37Z

Will check when I get back On Sep 30, 2023, at 10:29 PM, Ziad Beyens ***@***.***> wrote: @shahriar-shojib<https://github.com/shahriar-shojib> We have a single type error in the playground template: [2023-09-30 at 18 27 31]<https://user-images.githubusercontent.com/19695832/271784254-f4173222-8722-4c8f-9365-c28201e06a34.png> Could you take a look? Will tip $50 for that one 🙂 — Reply to this email directly, view it on GitHub<#2652 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABRUFBTNJEAWTRIWL4JMXYDX5BCGBANCNFSM6AAAAAA5KZZBF4>. You are receiving this because you were mentioned.Message ID: ***@***.***>

shahriar-shojib added 2 commits September 28, 2023 17:21

convert to tsup

2095d1f

added changeset

694a1e7

reviewpad bot added the large Pull request is large label Sep 28, 2023

algora-pbc bot mentioned this pull request Sep 28, 2023

Replace rollup by tsup as building tool #2627

Closed

algora-pbc bot added the 🙋 Bounty claim label Sep 28, 2023

rishi-raj-jain reviewed Sep 28, 2023

View reviewed changes

vercel bot had a problem deploying to Preview September 28, 2023 11:35 Failure

removed unnecessary tsup options

1a0b367

vercel bot had a problem deploying to Preview September 28, 2023 11:40 Failure

[test] don't use turbo cache on ci

cc00a3e

vercel bot had a problem deploying to Preview September 28, 2023 17:34 Failure

[test] allow manual workflow runs

b217649

vercel bot had a problem deploying to Preview September 28, 2023 17:54 Failure

[test] update concurrency on test

b9fb475

vercel bot had a problem deploying to Preview September 28, 2023 19:31 Failure

[test] adjust jest concurrency

b5d4312

vercel bot had a problem deploying to Preview September 28, 2023 20:02 Failure

adjust concurrency for test

adf5df8

switch to @swc/core nextjs conditional config revert ci edits

shahriar-shojib marked this pull request as ready for review September 30, 2023 09:53

shahriar-shojib and others added 3 commits September 30, 2023 15:54

update p:build:watch script

d0633e1

cleanup watcher script

feab45a

Merge branch 'main' into main

e40073b

vercel bot deployed to Preview September 30, 2023 10:19 View deployment

fix dev script

75764dc

vercel bot deployed to Preview September 30, 2023 10:54 View deployment

🩹 is-hotkey

4f42820

zbeyens and others added 4 commits September 30, 2023 12:57

Merge branch 'main' into shahriar-shojib/main

6b7d169

added turbowatch

2b80516

Merge branch 'shahriar-shojib/main' of github.com:udecode/plate

f018b8d

package json sorting

6e86cb7

vercel bot deployed to Preview September 30, 2023 11:26 View deployment

revert <AnyObject> changes

376a078

convert AnyObject from interface to type convert TElement from interface to type convert TTest from interface to type remove tsx package & dev script

Merge branch 'main' into main

67c50a9

zbeyens reviewed Sep 30, 2023

View reviewed changes

packages/core/src/types/plugin/PlatePlugin.ts Outdated Show resolved Hide resolved

zbeyens reviewed Sep 30, 2023

View reviewed changes

packages/core/src/utils/pluginInjectProps.ts Outdated Show resolved Hide resolved

shahriar-shojib added 2 commits September 30, 2023 20:35

remove unnecessary exports

3cc78f6

updated lockfile

a0d56f4

vercel bot deployed to Preview September 30, 2023 14:58 View deployment

zbeyens merged commit 4a99899 into udecode:main Sep 30, 2023
5 checks passed

zbeyens mentioned this pull request Sep 30, 2023

Version Packages #2657

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

convert to tsup #2652

convert to tsup #2652

shahriar-shojib commented Sep 28, 2023 •

edited

Loading

changeset-bot bot commented Sep 28, 2023 •

edited

Loading

vercel bot commented Sep 28, 2023 •

edited

Loading

reviewpad bot commented Sep 28, 2023

rishi-raj-jain Sep 28, 2023

shahriar-shojib Sep 28, 2023

zbeyens Sep 28, 2023

shahriar-shojib commented Sep 28, 2023

shahriar-shojib commented Sep 28, 2023

zbeyens commented Sep 28, 2023 •

edited

Loading

shahriar-shojib commented Sep 28, 2023

zbeyens commented Sep 28, 2023 •

edited

Loading

shahriar-shojib commented Sep 28, 2023

shahriar-shojib commented Sep 28, 2023

shahriar-shojib commented Sep 28, 2023

zbeyens commented Sep 28, 2023

zbeyens commented Sep 30, 2023 •

edited

Loading

zbeyens commented Sep 30, 2023 •

edited

Loading

shahriar-shojib commented Sep 30, 2023

shahriar-shojib commented Sep 30, 2023

zbeyens commented Sep 30, 2023 •

edited

Loading

shahriar-shojib commented Sep 30, 2023

shahriar-shojib commented Sep 30, 2023

shahriar-shojib commented Sep 30, 2023 via email

convert to tsup #2652

convert to tsup #2652

Conversation

shahriar-shojib commented Sep 28, 2023 • edited Loading

changeset-bot bot commented Sep 28, 2023 • edited Loading

🦋 Changeset detected

vercel bot commented Sep 28, 2023 • edited Loading

reviewpad bot commented Sep 28, 2023

rishi-raj-jain Sep 28, 2023

Choose a reason for hiding this comment

shahriar-shojib Sep 28, 2023

Choose a reason for hiding this comment

zbeyens Sep 28, 2023

Choose a reason for hiding this comment

shahriar-shojib commented Sep 28, 2023

shahriar-shojib commented Sep 28, 2023

zbeyens commented Sep 28, 2023 • edited Loading

shahriar-shojib commented Sep 28, 2023

zbeyens commented Sep 28, 2023 • edited Loading

shahriar-shojib commented Sep 28, 2023

shahriar-shojib commented Sep 28, 2023

shahriar-shojib commented Sep 28, 2023

zbeyens commented Sep 28, 2023

zbeyens commented Sep 30, 2023 • edited Loading

zbeyens commented Sep 30, 2023 • edited Loading

shahriar-shojib commented Sep 30, 2023

shahriar-shojib commented Sep 30, 2023

zbeyens commented Sep 30, 2023 • edited Loading

shahriar-shojib commented Sep 30, 2023

shahriar-shojib commented Sep 30, 2023

shahriar-shojib commented Sep 30, 2023 via email

shahriar-shojib commented Sep 28, 2023 •

edited

Loading

changeset-bot bot commented Sep 28, 2023 •

edited

Loading

vercel bot commented Sep 28, 2023 •

edited

Loading

zbeyens commented Sep 28, 2023 •

edited

Loading

zbeyens commented Sep 28, 2023 •

edited

Loading

zbeyens commented Sep 30, 2023 •

edited

Loading

zbeyens commented Sep 30, 2023 •

edited

Loading

zbeyens commented Sep 30, 2023 •

edited

Loading