Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
convert to tsup #2652
convert to tsup #2652
Changes from 2 commits
2095d1f
694a1e7
1a0b367
cc00a3e
b217649
b9fb475
b5d4312
adf5df8
fbca0f6
202c544
d60d400
eb1f4e8
1b87085
7791e9c
bbbd8ed
b8be697
dea9b41
390c1a6
020c5eb
71280b9
d0633e1
feab45a
e40073b
75764dc
4f42820
6b7d169
2b80516
f018b8d
6e86cb7
376a078
67c50a9
3cc78f6
a0d56f4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this required?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this will skip bundling of anything imported that is not local to the package even if it is a dependency.
Ideally, for packages like these, I think it's best not to bundle node_module packages in the build files since it will be taken care of by the end user's bundler.
Since we're not shipping browser bundles this provides some safety in my opinion.
If you think this is unnecessary I can remove it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will test it on next release