-
-
Notifications
You must be signed in to change notification settings - Fork 755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TablePlugin] Table cells merging POC #2590
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Will check it |
…lls-merging-poc-2 # Conflicts: # packages/table/src/transforms/insertTableRow.ts # yarn.lock
Continues in #2666 |
Summary
What had been done
Things to consider
insertTableRow
andinsertTableColumn
calls keep state ofcolIndex
,rowIndex
,colSpan
,rowSpan
for all cells. So running them multiple times synchronously won't lead to a problems.deleteColumn
,deleteRow
,mergeCells
,unmergeCells
will modify cells structure and won't updatecolIndex
,rowIndex
,colSpan
,rowSpan
for affected cells. It's ok, since valid indexes and spans will be assigned inuseTableCellElementState
hook on each render, but invoking that functions multiple times synchronously won't work.Functionality
merging.mp4
Pasting from Word
pasting-from-word.mp4
Pasting from other sites
pasting-from-sites.mp4