Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dts #2659

Merged
merged 5 commits into from
Oct 1, 2023
Merged

Fix dts #2659

merged 5 commits into from
Oct 1, 2023

Conversation

zbeyens
Copy link
Member

@zbeyens zbeyens commented Sep 30, 2023

Description

By @shahriar-shojib

@changeset-bot
Copy link

changeset-bot bot commented Sep 30, 2023

🦋 Changeset detected

Latest commit: 7be68e7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 54 packages
Name Type
@udecode/slate Patch
@udecode/plate-test-utils Patch
@udecode/plate-common Patch
@udecode/plate-core Patch
@udecode/plate-utils Patch
@udecode/slate-react Patch
@udecode/slate-utils Patch
@udecode/plate-alignment Patch
@udecode/plate-autoformat Patch
@udecode/plate-basic-elements Patch
@udecode/plate-basic-marks Patch
@udecode/plate-block-quote Patch
@udecode/plate-break Patch
@udecode/plate-caption Patch
@udecode/plate-cloud Patch
@udecode/plate-code-block Patch
@udecode/plate-combobox Patch
@udecode/plate-comments Patch
@udecode/plate-cursor Patch
@udecode/plate-dnd Patch
@udecode/plate-emoji Patch
@udecode/plate-excalidraw Patch
@udecode/plate-find-replace Patch
@udecode/plate-floating Patch
@udecode/plate-font Patch
@udecode/plate-heading Patch
@udecode/plate-highlight Patch
@udecode/plate-horizontal-rule Patch
@udecode/plate-indent-list Patch
@udecode/plate-indent Patch
@udecode/plate-juice Patch
@udecode/plate-kbd Patch
@udecode/plate-line-height Patch
@udecode/plate-link Patch
@udecode/plate-list Patch
@udecode/plate-media Patch
@udecode/plate-mention Patch
@udecode/plate-node-id Patch
@udecode/plate-normalizers Patch
@udecode/plate-paragraph Patch
@udecode/plate Patch
@udecode/plate-reset-node Patch
@udecode/plate-resizable Patch
@udecode/plate-select Patch
@udecode/plate-selection Patch
@udecode/plate-serializer-csv Patch
@udecode/plate-serializer-docx Patch
@udecode/plate-serializer-html Patch
@udecode/plate-serializer-md Patch
@udecode/plate-suggestion Patch
@udecode/plate-tabbable Patch
@udecode/plate-table Patch
@udecode/plate-trailing-block Patch
@udecode/plate-yjs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Sep 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
plate ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 1, 2023 8:49am

@zbeyens zbeyens changed the title 👷 Fix dts Sep 30, 2023
@reviewpad reviewpad bot added the small Pull request is small label Sep 30, 2023
@zbeyens
Copy link
Member Author

zbeyens commented Sep 30, 2023

@shahriar-shojib Could you take a look at this error?

@zbeyens
Copy link
Member Author

zbeyens commented Oct 1, 2023

@shahriar-shojib another issue I see is that the bundle size is bigger. For example, lodash is now included vs before

@zbeyens
Copy link
Member Author

zbeyens commented Oct 1, 2023

I have added an eslint rule import/no-extraneous-dependencies so all dependencies are not missing anymore, including lodash. That may fix it. Will confirm on release.

@reviewpad reviewpad bot added large Pull request is large and removed small Pull request is small labels Oct 1, 2023
@shahriar-shojib
Copy link
Collaborator

@shahriar-shojib Could you take a look at this error?

@shahriar-shojib another issue I see is that the bundle size is bigger. For example, lodash is now included vs before

will check both of these issues and update, could you please add me to vercel?

@zbeyens
Copy link
Member Author

zbeyens commented Oct 1, 2023

@zbeyens zbeyens merged commit fb4e05f into main Oct 1, 2023
6 checks passed
@zbeyens zbeyens deleted the fix/dts branch October 1, 2023 09:03
@zbeyens zbeyens mentioned this pull request Oct 1, 2023
@zbeyens
Copy link
Member Author

zbeyens commented Oct 1, 2023

@shahriar-shojib The dts update made the CI to fail. I'll do a test release in the meantime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
large Pull request is large
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants