Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable tabbable when editor is read-only #2665

Merged
merged 2 commits into from
Oct 2, 2023
Merged

Conversation

12joan
Copy link
Collaborator

@12joan 12joan commented Oct 2, 2023

The tabbable plugin doesn't work correctly when the editor is read-only, causing the focus to get stuck inside focusable DOM elements.

@12joan 12joan requested a review from zbeyens October 2, 2023 15:01
@changeset-bot
Copy link

changeset-bot bot commented Oct 2, 2023

🦋 Changeset detected

Latest commit: 64c496a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@udecode/plate-tabbable Patch
@udecode/plate Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
plate ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 2, 2023 4:04pm

@reviewpad reviewpad bot added the small Pull request is small label Oct 2, 2023
@zbeyens zbeyens merged commit 38d465e into main Oct 2, 2023
6 checks passed
@zbeyens zbeyens deleted the fix/tabbable-read-only branch October 2, 2023 16:09
@zbeyens zbeyens mentioned this pull request Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
small Pull request is small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants