Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX #2677 : CommonJS validator import in cleanDocXImageElements #2678

Merged
merged 2 commits into from
Oct 5, 2023

Conversation

rcbevans
Copy link
Contributor

@rcbevans rcbevans commented Oct 4, 2023

Description

Replace import isURL from 'validator/lib/isURL' with import validator from 'validator' to fix CommonJS import issue when using esModules under vitest.

@changeset-bot
Copy link

changeset-bot bot commented Oct 4, 2023

🦋 Changeset detected

Latest commit: ab3bf86

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@udecode/plate-serializer-docx Patch
@udecode/plate Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
plate ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 5, 2023 6:04am

@reviewpad
Copy link
Contributor

reviewpad bot commented Oct 4, 2023

Thank you @rcbevans for this first contribution!

@zbeyens
Copy link
Member

zbeyens commented Oct 5, 2023

Thanks!

@zbeyens zbeyens merged commit b4ae597 into udecode:main Oct 5, 2023
4 checks passed
@zbeyens zbeyens mentioned this pull request Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
small Pull request is small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants