Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: "Cannot resolve a DOM node from Slate node" floating link case #2705

Merged
merged 2 commits into from
Oct 17, 2023
Merged

Fix: "Cannot resolve a DOM node from Slate node" floating link case #2705

merged 2 commits into from
Oct 17, 2023

Conversation

AndreyMarchuk
Copy link
Contributor

Fix exception when Enter is pressed in link input.

Description

Fix issue when pressing Enter in link input on floating toolbar with latest plate/slate:
#2674

Steps to reproduce:

  • select text
  • click "link" on a floating toolbar
  • enter some url and click enter -> exception "Cannot resolve a DOM node from Slate node"

Fix #2674 when Enter is pressed on link floating toolbar
@changeset-bot
Copy link

changeset-bot bot commented Oct 17, 2023

🦋 Changeset detected

Latest commit: a290ecc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@udecode/plate-link Patch
@udecode/plate Patch
@udecode/plate-serializer-md Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
plate ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2023 8:10am

@reviewpad
Copy link
Contributor

reviewpad bot commented Oct 17, 2023

Thank you @AndreyMarchuk for this first contribution!

@zbeyens zbeyens merged commit 2de5ea7 into udecode:main Oct 17, 2023
4 checks passed
@zbeyens zbeyens mentioned this pull request Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
small Pull request is small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants