-
-
Notifications
You must be signed in to change notification settings - Fork 757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Whitespace in pasted HTML is not handled according to the HTML spec #2715
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
62 changes: 56 additions & 6 deletions
62
packages/core/src/plugins/html-deserializer/utils/htmlStringToDOMNode.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,16 +1,66 @@ | ||
/** | ||
* Convert HTML string into HTML element. | ||
* Convert HTML string into HTML element with custom white-space handling. | ||
*/ | ||
export const htmlStringToDOMNode = ( | ||
rawHtml: string, | ||
stripWhitespace = true | ||
stripWhitespace = true, | ||
preElementBehavior = true | ||
) => { | ||
const node = document.createElement('body'); | ||
node.innerHTML = rawHtml; | ||
|
||
if (stripWhitespace) { | ||
node.innerHTML = node.innerHTML.replaceAll(/(\r\n|[\t\n\r])/g, ''); | ||
const computedStyle = window.getComputedStyle(node); | ||
// Process based on the specified white-space value | ||
switch (computedStyle.whiteSpace) { | ||
case 'normal': { | ||
if (stripWhitespace) { | ||
// Collapse spaces and tabs, wrap text, remove end-of-line spaces | ||
node.innerHTML = node.innerHTML.replaceAll(/[\t\r]*\n[\t\r ]*/g, ' '); | ||
} | ||
break; | ||
} | ||
case 'nowrap': { | ||
if (stripWhitespace) { | ||
// Collapse spaces and tabs, no text wrap, remove end-of-line spaces | ||
node.innerHTML = node.innerHTML.replaceAll(/[\t\r]*\n[\t\r ]*/g, ' '); | ||
} | ||
break; | ||
} | ||
case 'pre': { | ||
// Preserve spaces and tabs, no text wrap, preserve end-of-line spaces | ||
break; | ||
} | ||
case 'pre-wrap': { | ||
// Preserve spaces and tabs, wrap text, preserve end-of-line spaces | ||
break; | ||
} | ||
case 'pre-line': { | ||
if (stripWhitespace) { | ||
// Preserve spaces, collapse tabs, wrap text, remove end-of-line spaces | ||
node.innerHTML = node.innerHTML.replaceAll('\t', ' '); | ||
} | ||
break; | ||
} | ||
case 'break-spaces': { | ||
// Preserve spaces and tabs, wrap text, wrap end-of-line spaces | ||
node.innerHTML = node.innerHTML.replaceAll(/[\t\r ]/g, ' '); | ||
break; | ||
} | ||
default: { | ||
// Use 'normal' behavior if the specified value is not recognized | ||
break; | ||
} | ||
} | ||
if (preElementBehavior) { | ||
// Check if the first element within the body is a PRE element | ||
const firstElement = node.firstElementChild; | ||
if ( | ||
firstElement && | ||
firstElement.tagName === 'PRE' && | ||
rawHtml.startsWith('\n') | ||
) { | ||
// Remove the leading newline character as per the HTML spec | ||
firstElement.textContent = rawHtml.slice(1); | ||
} | ||
} | ||
|
||
return node; | ||
}; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure checking the computed style of the top-level element is going to work. The HTML to be deserialized may contain a mixture of different whitespace modes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this doesn't work, you could try walking the DOM tree in a recursive function while keeping track of the current whitespace mode. Then you could transform each text node as you arrive at it according to the rules.