Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Whitespace in pasted HTML is not handled according to the HTML spec #2715

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,16 +1,66 @@
/**
* Convert HTML string into HTML element.
* Convert HTML string into HTML element with custom white-space handling.
*/
export const htmlStringToDOMNode = (
rawHtml: string,
stripWhitespace = true
stripWhitespace = true,
preElementBehavior = true
) => {
const node = document.createElement('body');
node.innerHTML = rawHtml;

if (stripWhitespace) {
node.innerHTML = node.innerHTML.replaceAll(/(\r\n|[\t\n\r])/g, '');
const computedStyle = window.getComputedStyle(node);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure checking the computed style of the top-level element is going to work. The HTML to be deserialized may contain a mixture of different whitespace modes.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this doesn't work, you could try walking the DOM tree in a recursive function while keeping track of the current whitespace mode. Then you could transform each text node as you arrive at it according to the rules.

// Process based on the specified white-space value
switch (computedStyle.whiteSpace) {
case 'normal': {
if (stripWhitespace) {
// Collapse spaces and tabs, wrap text, remove end-of-line spaces
node.innerHTML = node.innerHTML.replaceAll(/[\t\r]*\n[\t\r ]*/g, ' ');
}
break;
}
case 'nowrap': {
if (stripWhitespace) {
// Collapse spaces and tabs, no text wrap, remove end-of-line spaces
node.innerHTML = node.innerHTML.replaceAll(/[\t\r]*\n[\t\r ]*/g, ' ');
}
break;
}
case 'pre': {
// Preserve spaces and tabs, no text wrap, preserve end-of-line spaces
break;
}
case 'pre-wrap': {
// Preserve spaces and tabs, wrap text, preserve end-of-line spaces
break;
}
case 'pre-line': {
if (stripWhitespace) {
// Preserve spaces, collapse tabs, wrap text, remove end-of-line spaces
node.innerHTML = node.innerHTML.replaceAll('\t', ' ');
}
break;
}
case 'break-spaces': {
// Preserve spaces and tabs, wrap text, wrap end-of-line spaces
node.innerHTML = node.innerHTML.replaceAll(/[\t\r ]/g, ' ');
break;
}
default: {
// Use 'normal' behavior if the specified value is not recognized
break;
}
}
if (preElementBehavior) {
// Check if the first element within the body is a PRE element
const firstElement = node.firstElementChild;
if (
firstElement &&
firstElement.tagName === 'PRE' &&
rawHtml.startsWith('\n')
) {
// Remove the leading newline character as per the HTML spec
firstElement.textContent = rawHtml.slice(1);
}
}

return node;
};
Loading