Copy table bugfix

[KorovinQuantori]

Description

Bugfix for #2767

[changeset-bot]

🦋 Changeset detected

Latest commit: d1040bd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages

Name	Type
@udecode/plate-table	Patch
@udecode/plate	Patch
@udecode/plate-serializer-csv	Patch
@udecode/plate-serializer-docx	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
plate	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 27, 2023 0:29am

[reviewpad]

Thank you @KorovinQuantori for this first contribution!

[12joan]

Thanks for the PR! Can you add a changeset and (if you don't mind, just because I'm curious) explain more about how the problem arises and why data.clearData() fixes it?

[12joan]

Actually, I can still reproduce the bug on the Vercel deployment for this branch.

recording.mp4

[KorovinQuantori]

Thanks for the PR! Can you add a changeset and (if you don't mind, just because I'm curious) explain more about how the problem arises and why data.clearData() fixes it?

Sure thing. The problem is described here: #2767. So, in general, lets say we have a row of 3 cells we want to copy. First cell is filled with "1", others are empty. In that case, on the first iteration of rowCells.forEach we'll set "1" in data buffer, but on the second and third we'll still get this "1" in buffer, because cells are empty. I suspect, it's either select section selects nothing, because the cell is empty or setFragmentData does nothing because we selected nothing.

BTW: I've updated PR, had a wrong insertion, when was copying it from my project. Could you tell me more about changeset and how to fill it properly?

[12joan]

Thanks for the explanation, that makes sense.

To add the changeset, run yarn changeset add. Since this is a non-breaking bug fix, you can select patch, and then describe what changed from a behavioural perspective. A one-line description of the fixed issue would suffice. Merging a PR containing a changeset starts the process to deploy new versions of the affected Plate packages.

[KorovinQuantori]

Thank you, added a changeset