Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Table] Fix merge headers #2832

Merged
merged 3 commits into from
Dec 26, 2023
Merged

[Table] Fix merge headers #2832

merged 3 commits into from
Dec 26, 2023

Conversation

dimaanj
Copy link
Collaborator

@dimaanj dimaanj commented Dec 26, 2023

Summary

  • Fixes merge of headers in table
  • rowSizeOverrides.get sometime were undefined, that is why added ooptional type check
  • collapseSelection helps not to select cells on merge

@dimaanj dimaanj requested a review from zbeyens December 26, 2023 15:05
@dimaanj dimaanj self-assigned this Dec 26, 2023
Copy link

changeset-bot bot commented Dec 26, 2023

🦋 Changeset detected

Latest commit: a0ee2e4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@udecode/plate-table Patch
@udecode/plate Patch
@udecode/plate-serializer-csv Patch
@udecode/plate-serializer-docx Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Dec 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
plate ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 26, 2023 3:35pm

@zbeyens
Copy link
Member

zbeyens commented Dec 26, 2023

2023-12-26.at.16.26.16.mp4

Just a partial fix but at least it prevents the crash.

Thanks for the PR @dimaanj

@zbeyens zbeyens merged commit 41f29f2 into udecode:main Dec 26, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clicking on any table border causes error: "rowSizeOverrides.get is not a function"
2 participants