Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: Empty list item Md deserialization error #2885

Merged
merged 2 commits into from
Jan 29, 2024

Conversation

FranciscoMoretti
Copy link
Contributor

Deserializing an empty list item in an indentList raised an error

For no children, this line would result in an undefined paragraph

const [paragraph, ...subLists] = listItem.children!;

Causing the subsequent conversion to fail.

Example:

- Item 1
- 

Copy link

changeset-bot bot commented Jan 20, 2024

🦋 Changeset detected

Latest commit: c09e55a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@udecode/plate-serializer-md Patch
@udecode/plate Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jan 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
plate ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 20, 2024 3:02pm

zbeyens
zbeyens previously approved these changes Jan 20, 2024
@FranciscoMoretti
Copy link
Contributor Author

Hey @zbeyens. This seems ready but I don't have merge permissions

@zbeyens zbeyens merged commit 0d73c01 into udecode:main Jan 29, 2024
6 checks passed
@zbeyens
Copy link
Member

zbeyens commented Jan 29, 2024

Sorry forgot that one. I generally land and release PRs in the next hours 😅 Thanks again for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants