-
-
Notifications
You must be signed in to change notification settings - Fork 755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: #3002 #3003
fix: #3002 #3003
Conversation
🦋 Changeset detectedLatest commit: 74c1c04 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
[Update: Fri - March 1st, 2024]: TL;DRUse CSR (client side rendering) for editor and its plugin to resolve the issue since the package For DetailsI have just forked the In my project, which is based on Astro, I am implementing SSR (Server-Side Rendering) to render the editor on the client. This means that the configuration and plugins run on the server along with the HTML before shipping some JS to the client to initialize the editor. Each time I run the command from the ---
import RootLayout from "@/common/layouts/root-layout.astro";
import WriteEditor from "@/modules/write/composites/write-editor";
---
<RootLayout title="Le-Insight | Write">
<WriteEditor client:load />
</RootLayout>
However, the After conducting some simple inspections that I missed the last time before creating this PR, I have decided to render the editor with its plugins on the client-side. ---
import RootLayout from "@/common/layouts/root-layout.astro";
import WriteEditor from "@/modules/write/composites/write-editor";
---
<RootLayout title="Le-Insight | Write">
<WriteEditor client:only="react" />
</RootLayout> Everything works as expected, rendering this PR POINTLESS. (My sincere apologies for my immature knowledge) However, we are still facing another problem since our API key for Portive Cloud is exposed on the client-side. The solution provided by Portive Cloud is to use createCloudPlugin({
options: {
authToken: async () => {
const response = await fetch("https://mysite.com/api/get-auth", {
method: "POST",
})
const json = await response.json()
return json.authToken
},
},
}) For more information, please visit: https://www.portive.com/docs/auth/intro#about-using-auth-tokens To the maintainer: Regarding this PR, you can consider closing it since my solution of changing the |
Thanks for the PR! |
Description
Please see some more information in the #3002 .