Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggle > injectToggle.tsx > Make hidden elements overflow hidden to account for inner elements with a vertical margin #3023

Merged
merged 3 commits into from
Mar 14, 2024

Conversation

Liboul
Copy link
Collaborator

@Liboul Liboul commented Mar 13, 2024

An element hidden by a toggle can still take some vertical space if an inner element has a vertical margin. This PR addresses this issue

…ccount for inner elements with a vertical margin
Copy link

changeset-bot bot commented Mar 13, 2024

🦋 Changeset detected

Latest commit: c53466b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@udecode/plate-toggle Patch
@udecode/plate Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Mar 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
plate ❌ Failed (Inspect) Mar 14, 2024 10:56am

@zbeyens zbeyens merged commit 624edd3 into main Mar 14, 2024
5 of 6 checks passed
@zbeyens zbeyens deleted the Liboul-toggle-fix-inner-elements-with-margin branch March 14, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants