Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Prism.js optional for @udecode/code-block #3282

Merged
merged 3 commits into from
Jun 23, 2024
Merged

Conversation

12joan
Copy link
Collaborator

@12joan 12joan commented Jun 13, 2024

@12joan 12joan requested a review from zbeyens June 13, 2024 17:28
Copy link

vercel bot commented Jun 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
plate ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 23, 2024 4:05pm

Copy link

changeset-bot bot commented Jun 13, 2024

🦋 Changeset detected

Latest commit: 1551e67

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@udecode/plate-code-block Major
@udecode/plate-basic-elements Major
@udecode/plate Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@12joan
Copy link
Collaborator Author

12joan commented Jun 13, 2024

@zbeyens Do you think this should be a major change or minor?

zbeyens
zbeyens previously approved these changes Jun 13, 2024
Copy link
Member

@zbeyens zbeyens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! It's indeed a major one.

@zbeyens
Copy link
Member

zbeyens commented Jun 13, 2024

cc @dylans

@zbeyens zbeyens merged commit 1fdf213 into main Jun 23, 2024
3 of 4 checks passed
@zbeyens zbeyens deleted the fix/make-prismjs-optional branch June 23, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants