Update caption UI when element caption property changes
#3287
Conversation
This happened when I ran `yarn` in my local repo using Node.js v18.20.3 and Yarn v4.1.0. Not sure if the problem's in my local environment or the repo itself.
🦋 Changeset detectedLatest commit: f805c83 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Thank you for your PR.You are right.But I found when we focus the textarea we can not redo.Are you interested in fixing this together?It might just require calling the |
|
I will fixes these later thanks again @TyMick |
|
Wow, thanks for the quick response! 🚀 Good point on losing the Slate undo/redo shortcuts when the textarea's focused. I did notice that, but it's not a priority for our team right now for a couple of reasons. First, the browser undo/redo will at least affect what's been typed in the textarea when the textarea's focused, and the caption plugin still syncs those contents with the Slate document. And second, we're including undo/redo buttons in our fixed editor toolbar, so those will still give our users access to Slate undo/redo functionality when they have a caption focused. Overriding the browser undo/redo in caption textareas would be a nice enhancement for the future, though! |
Currently, the caption plugin is using an internal React state variable as the source of truth for the caption value. While it is updating the Slate element's
captionproperty when the caption value changes, it is only reading the elementcaptionproperty to set the initial value of the aforementioned React state. So after the caption mounts, external changes to the element'scaptionproperty do not get reflected in the caption textarea.In my app, this bug is most apparent when using undo/redo. After typing some text into a caption textarea, the undo action will revert one character at a time in the
captionproperty on the element itself, but the caption textarea will remain unchanged.This PR removes the internal React state variable and uses the element's
captionproperty as the source of truth for the caption value. This change fixes the bug in my own app.