Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix table column count when first row has merged columns #3368

Merged
merged 7 commits into from
Jul 26, 2024

Conversation

beeant0512
Copy link
Contributor

Checklist

  • yarn typecheck
  • yarn lint:fix
  • yarn test
  • yarn brl

Copy link

changeset-bot bot commented Jul 15, 2024

🦋 Changeset detected

Latest commit: 289fd03

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@udecode/plate-table Patch
@udecode/plate Patch
@udecode/plate-serializer-csv Patch
@udecode/plate-serializer-docx Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jul 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
plate ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 26, 2024 1:44am

zbeyens
zbeyens previously approved these changes Jul 15, 2024
@zbeyens zbeyens self-requested a review July 25, 2024 10:34
Copy link
Member

@zbeyens zbeyens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, could you fix the tests?

@udecode/plate-serializer-html src/__tests__/serializeHtml/elements.spec.ts (13.78 s)
    TypeError: Cannot read properties of undefined (reading 'map')
@zbeyens zbeyens merged commit be8c749 into udecode:main Jul 26, 2024
6 checks passed
@beeant0512 beeant0512 deleted the fix/table-column-count branch July 31, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants