fix: corrected toggle calls for Superscript and Subscript #3402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f31b4c3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
hamza-hadj-aissa
force-pushed
the
fix/more-dropdown-menu
branch
from
e3ed04c to
a3d7b91
Compare
hamza-hadj-aissa
force-pushed
the
fix/more-dropdown-menu
branch
from
a3d7b91 to
f31b4c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Descripition
The
MoreDropdownMenucomponent had incorrect behavior for toggling the Superscript and Subscript marks. The behavior of these marks was swapped; selecting Superscript was incorrectly setting the Subscript mark and vice versa. Additionally, theclearandkeyparameters needed adjustments to ensure the correct mark is toggled while clearing the other.Summary of Changes:
clearparameter to include bothMARK_SUBSCRIPTandMARK_SUPERSCRIPT.keyvalues for Superscript and Subscript, which were previously swapped.Checklist:
yarn typecheckyarn lint:fixyarn testyarn brlyarn changesetChangelog Update