Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mermaid to list of supported languages #3416

Merged
merged 5 commits into from
Aug 12, 2024
Merged

Add mermaid to list of supported languages #3416

merged 5 commits into from
Aug 12, 2024

Conversation

dylans
Copy link
Collaborator

@dylans dylans commented Aug 5, 2024

Excalidraw has a mermaid to excalidraw plugin, so we should add mermaid to the list of languages to make it easier for someone to add a convert from mermaid to excalidraw option.

Checklist

  • yarn typecheck
  • yarn lint:fix
  • yarn test
  • yarn brl
  • yarn changeset
  • ui changelog

Excalidraw has a mermaid to excalidraw plugin, so we should add mermaid to the list of languages to make it easier for someone to add a convert from mermaid to excalidraw option.
Copy link

vercel bot commented Aug 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
plate ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 12, 2024 0:14am

Copy link

changeset-bot bot commented Aug 5, 2024

⚠️ No Changeset found

Latest commit: d91dbe3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dylans
Copy link
Collaborator Author

dylans commented Aug 6, 2024

Note, I'm not sure if I have the package name correct for the changelog.

This is part of some work I'm doing to update excalidraw so that it will actually work for people more easily out of the box.

@dylans dylans marked this pull request as ready for review August 6, 2024 19:23
@zbeyens
Copy link
Member

zbeyens commented Aug 6, 2024

You can remove that changeset, you'll just need to update https://github.com/udecode/plate/blob/main/apps/www/content/docs/components/changelog.mdx since it's not part of the packages

@dylans dylans requested a review from zbeyens August 12, 2024 12:06
@zbeyens zbeyens merged commit 7c73e6c into main Aug 12, 2024
3 of 4 checks passed
@zbeyens zbeyens deleted the code-block-mermaid branch August 12, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants