Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support composition event in placeholder #3500

Merged
merged 4 commits into from
Sep 3, 2024

Conversation

yf-yang
Copy link
Collaborator

@yf-yang yf-yang commented Sep 3, 2024

Checklist

  • yarn typecheck
  • yarn lint:fix
  • yarn test
  • yarn brl
  • yarn changeset
  • ui changelog

fixes #3425
fixes #3250

Copy link

codesandbox bot commented Sep 3, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

changeset-bot bot commented Sep 3, 2024

🦋 Changeset detected

Latest commit: 3e7a508

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@udecode/plate-utils Patch
@udecode/plate-common Patch
@udecode/plate Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Sep 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
plate ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 3, 2024 7:42am

Copy link
Collaborator

@12joan 12joan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work coordinating this fix between slate-react and Plate 👍

.changeset/orange-months-sort.md Outdated Show resolved Hide resolved
.changeset/orange-months-sort.md Outdated Show resolved Hide resolved
@12joan 12joan merged commit 75018b4 into udecode:main Sep 3, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The placeholder remains visible when composing using an IME
2 participants