-
Notifications
You must be signed in to change notification settings - Fork 766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compute cell indices, table unmerge, delete row / column, add row / column, copy table data #3552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 44544cd The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…electing multiple cells and copying
natamox
changed the title
Fix unmerge & compute cell indices
Fix unmerge, compute cell indices, delete row / column, add row / column
Sep 20, 2024
Great job @natamox , thanks! |
natamox
changed the title
Fix unmerge, compute cell indices, delete row / column, add row / column
Fix table unmerge / merge, compute cell indices, delete row / column, add row / column
Jan 16, 2025
natamox
changed the title
Fix table unmerge / merge, compute cell indices, delete row / column, add row / column
Fix table unmerge, compute cell indices, delete row / column, add row / column
Jan 16, 2025
natamox
changed the title
Fix table unmerge, compute cell indices, delete row / column, add row / column
Fix compute cell indices, table unmerge, delete row / column, add row / column
Jan 16, 2025
natamox
changed the title
Fix compute cell indices, table unmerge, delete row / column, add row / column
Fix compute cell indices, table unmerge, delete row / column, add row / column, copy table data
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problems encountered in the table now:
When splitting cells, deleting and adding rows and columns, the table format will be disordered and cells will be missing. In the end, I found that all the errors are related to a function (computeAllCellIndices). Because the result of this function is wrong, the subsequent process goes in the wrong direction, and the splitting, adding and deleting all lack consideration for certain special situations, which leads to errors.
Solution: