Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release] Version packages #3571

Merged
merged 1 commit into from
Sep 23, 2024
Merged

[Release] Version packages #3571

merged 1 commit into from
Sep 23, 2024

Conversation

github-actions[bot]
Copy link
Contributor

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.

Releases

@udecode/[email protected]

Patch Changes

  • #3569 by @felixfeng33 – Remove the Div rendered above the editor.

    This div is to solve the issue of the browser's default scrolling behavior being too fast.

    However, it caused some other issues and complicated configurations, such as being unable to focus on the editor when clicking the padding-right area.

    If you think this issue is more important, you refer to the flowing code.

      BlockSelectionPlugin.configure({
        render: {
          aboveEditable: ({ children }) => {
        return ( <div style={{ position: 'relative', width: '100%' }}>
          {/*
           *select text then move cursor to the very bottom will trigger the default browser behavior
           *this div is a workaround to prevent the default browser behavior (set userSelect: none)
           *Make sure the div with is the same with the editor's padding-right
           */}
    
          {/* TODO: click to focus the node */}
          <div
            style={{
              height: '100%',
              position: 'absolute',
              right: 0,
              top: 0,
              userSelect: 'none',
              width: editorPaddingRight ?? 'max(5%, 24px)',
              zIndex: 1,
            }}
            data-plate-selectable
          />
          {children}
          </div>)
      },
        },
      }),

@udecode/[email protected]

Copy link

vercel bot commented Sep 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
plate ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 23, 2024 11:34am

Copy link

codesandbox bot commented Sep 23, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@felixfeng33 felixfeng33 merged commit 177a05e into main Sep 23, 2024
2 of 3 checks passed
@felixfeng33 felixfeng33 deleted the changeset-release/main branch September 23, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant